Repository navigation
Restore benchmark metric registry after property tests - #1550
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark property tests clear the shared metric registry without restoring it. Running them before benchmark regressions removes built-in metrics and causes six later tests to return
NaNmodularity.Snapshot and restore the registry around each property test, including failure paths.
Validation: the combined run has 6 failures on the base revision; all 58 property, benchmark, and DSL tests pass with the fixture.
CI caveat: existing workflows suppress pytest failures; the focused validation above was run directly.