Repository navigation
Respect undirected edge identity in layer Jaccard similarity - #1552
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer edge Jaccard similarity treats undirected endpoints as ordered, so identical layers can appear disjoint solely because nodes were inserted in opposite orders. Use unordered edge identities for undirected graphs while preserving directed orientation.
Validation: 3 regressions fail on master and all 5 pass after the fix (simple/multigraph, directed controls, self-loops, mixed IDs). Broader checks: 96 passed; one unchanged node-overlap test also fails on untouched master. Diff check and regression-test Ruff pass; source Ruff findings are pre-existing.