Skip to content

Preserve executable layer sets in AST JSON - #1566

Open
SkBlaz wants to merge 2 commits into
masterfrom
fix/joss-layer-set-json-20261012
Open

SkBlaz wants to merge 2 commits into
masterfrom
fix/joss-layer-set-json-20261012

Conversation

@SkBlaz

@SkBlaz SkBlaz commented Oct 12, 2026

Copy link
Copy Markdown
Owner

AST JSON turns LayerSet objects into display strings, so saved layer-algebra queries cannot execute when reconstructed. Serialize the expression tree with distinct type tags and restore LayerSet objects, preserving literal names and late binding without confusing the legacy LayerExpr type.

Local AST/layer/provenance checks: 159 passed; one existing target-enum hash failure reproduced on untouched base (covered by open #1559). Regression Ruff and diff checks passed. GitHub CI intentionally skipped at the user's request.

@SkBlaz

SkBlaz commented Oct 13, 2026

Copy link
Copy Markdown
Owner Author

@copilot resolve the merge conflicts in this pull request

…json-20261012

# Conflicts:
#	py3plex/dsl/ast.py

Co-authored-by: SkBlaz <10035780+SkBlaz@users.noreply.github.com>

Copilot AI commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Merged master, resolved the AST JSON conflict while retaining both LayerSet and legacy Target deserialization paths, and published merge commit 888b0c7.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants