refactor!: remove threads parameters; parallelism always uses all available CPU threads - #142
Merged
Conversation
…ilable CPU threads Drop --threads/-t from build-kg and build-fullmap, --gepa-threads from the agent command, and the threads/num_threads parameters from the Python API and Rust pyfunctions. Fullmap builds and lookups now always use the previous automatic default: all available CPU threads, with builds memory-capped on Linux (~2 GB/thread) and lookups parallelized for batches of 1024+ terms.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SkyeAv
added a commit
that referenced
this pull request
Sep 8, 2026
Cut 17.0.0 and bump the package version in pyproject.toml, uv.lock, and CITATION.cff. Major: the parallelism surface is removed (#142) - the `--threads` / `-t` flags on `build-kg` and `build-fullmap`, the agent command's `--gepa-threads` flag, and the `threads` / `num_threads` parameters on the Python and Rust pyfunctions are gone; migration is to drop those arguments, since the automatic behavior is exactly the previous default (all CPU threads, fullmap builds memory-capped on Linux, lookups parallelized for batches of 1024+ terms) and results are unchanged. Also shipping: the `uuid_on_collision: merge` fold is near-linear and the canonical serializer allocation-free (#143) - up to 28.6x on merge-heavy workloads and 14.6% faster in default `error` mode, with byte-identical output. Changelog: - Versioned the Unreleased section as 17.0.0, renamed its `### Removed` subsection to `### Breaking Changes`, gave the threads-removal entry its PR link and a migration note, and moved the #143 Performance entry out of the already-released 16.6.2 section, where it had been misfiled, into 17.0.0. Docs: docs/cli.md, docs/fullmap.md, docs/api/fullmap.md, docs/agent.md, and examples/agent/README.md were updated by #142 itself; none needed here - the release commit touches version metadata and CHANGELOG.md only. Testing: - uv run pytest -q -> 1243 passed, 3 skipped (96% coverage) - uv run ruff check . && uv run ruff format --check . && uv run pyright -> clean / 0 errors - uv lock --check -> up to date - uv run mkdocs build --strict -> clean - cargo fmt --check && cargo clippy --all-targets -- -D warnings -> clean (rust/ touched)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes every user-facing thread-count knob. Parallelism is now always automatic, using all available CPU threads.
Removed
--threads/-tfromtablassert build-kgandtablassert build-fullmap--gepa-threadsfrom theagentcommand (GEPA now uses its library-default pool)threads/num_threadsparameters from the Python API (resolve,resolve_batch,lookup_rows, pipelines,run_gepa,Tcode) and the Rust pyfunctions (build_fullmap_db,lookup_fullmap_terms)Behavior (previously the
threads=Nonedefault, now the only path)MemAvailableper thread) to avoid OOMsbuild_fullmap_inner/build_testkeep explicit worker counts so serial-vs-parallel determinism tests are preservedDocs — thread-flag rows removed from
docs/cli.md,docs/fullmap.md,docs/api/fullmap.md,docs/agent.md,examples/agent/README.md; each now documents that parallelism is automatic. NewUnreleasedCHANGELOG entry. The separateTABLASSERT_FULLMAP_PRODUCERSenv knob is unchanged.Verification
ruff,cargo fmt --check,clippy -D warnings,pyright(0 errors) all clean--threadsis rejected as an unknown optionBREAKING CHANGE:
--threads/-t,--gepa-threads, and thethreads/num_threadsAPI parameters no longer exist.