fix(fullmap): retain tied CURIE matches - #145
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SkyeAv
added a commit
that referenced
this pull request
Sep 9, 2026
Cut 17.0.1 and bump the package version in pyproject.toml, CITATION.cff, and uv.lock. Patch: the fullmap resolver now retains every CURIE tied on a term's best ranking tier (#145) — `distinct` used to keep one arbitrary sort-first row per term, silently discarding distinct CURIEs tied across the entire ranking tuple; tied CURIEs now propagate through `resolve`, `resolve_batch`, and `join_matches` as separate output rows, collapsed only by `(term, CURIE)`. Also on main since 17.0.0: a CI-only GitHub Actions runtime bump (#144), no user-facing change. Changelog: - Versioned the release as 17.0.1 - 2026-09-09 with one Fixed entry for the tied-CURIE retention (#145); no Unreleased section existed to rename, and the CI-only bump (#144) gets no entry per repo convention. Docs: none needed here — #145 shipped its docs updates (docs/api/fullmap.md) with the fix. Testing: - make lint -> "All checks passed!" (ruff check) - make fmt-check -> 84 files already formatted; cargo fmt clean - make typecheck -> 0 errors, 0 warnings, 0 informations (pyright) - make test -> 1246 passed, 3 skipped in 37.52s (pytest, 96% coverage) - make test-rust -> all test binaries ok (cargo test) - cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings -> clean - uv lock --check -> in sync pre-bump; re-locked post-bump, self-entry only
SkyeAv
added a commit
to glusman-team/dakp
that referenced
this pull request
Sep 9, 2026
17.0.1 makes the fullmap resolver retain every CURIE tied on a term's best ranking tier instead of keeping one arbitrary winner (SkyeAv/Tablassert#145): `distinct` sorted by term/PR/NLP_LEVEL and kept only the first row per term, so CURIEs tied across the whole ranking tuple were discarded before `resolve` saw them. A DAKP mention that maps equally well to several CURIEs now expands to one edge per tied CURIE (level-one still beats level-two). Nothing in the emitted config changes — only resolved KG content — so the pin, the version-history docs, and the package version move. The version bump regenerates tables/graph.yaml, which embeds the DAKP package version via graph_config(version=...), and carries CITATION.cff along. Verified against the installed 17.0.1: `make check` (ruff check + format check, pyright 0 errors, uv run pytest = 1066 passed at 100.00% branch coverage including the real tablassert build-kg KGX end-to-end, merge-on- collision and nullable-qualifier integration tests, go test ./..., go vet).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(term, CURIE)resolve()andjoin_matches()as separate rowsVerification
uv run pytest tests/test_fullmap.py tests/test_fullmap_golden.pyuv run pytest -n0(1246 passed, 3 skipped)make lintmake fmt-checkmake typecheck