Repository navigation
feat(db): add connection pool configuration and metrics - #1813
Merged
github-actions[bot] merged 1 commit intoOct 17, 2026
Merged
github-actions[bot] merged 1 commit into
github-actions[bot] merged 1 commit into
Conversation
…1797) Expose pool configuration with sane defaults and add a metrics collector that samples pool health counters (total, idle, waiting, active, utilization) for monitoring and alerting. Changes: - Add PoolTuningOptions to DatabaseConfig: min connections, max client uses, query wait warning threshold, metrics enable/interval/alert threshold - Create PoolMetricsCollector class with periodic sampling, edge-triggered alerts on utilization threshold crossing, and health summary endpoint data - Add max property to Pool interface for metrics derivation - Export PoolMetricsCollector and types from connectionPool module - Document all pool env vars in .env.example - Add comprehensive tests for pool metrics (12 test cases) and pool tuning config (4 test cases) Acceptance criteria: - [x] Configurable — all pool sizing via env vars with documented defaults - [x] Metrics exposed — PoolMetricsCollector produces structured snapshots with utilization, saturation, and health summary - [x] Tested — 16 new test cases covering metrics collection, alerting, and configuration loading
|
@favvy0217 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1797
Exposes pool configuration with sane defaults and adds a metrics collector that samples pool health counters for monitoring and alerting.
Changes
Acceptance Criteria