Repository navigation
feat: export header builders and add security header audit tests - #1824
Merged
github-actions[bot] merged 1 commit intoOct 17, 2026
Conversation
|
@aniokedianne Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1773
Closes #1774
Closes #1775
Closes #1759
What changed
buildHstsandbuildPermissionsPolicywere unexported private functions, butsecurityHeaders.test.tsalready imported them — causing silentundefinedimports at test time. This PR exports both helpers and adds aSecurity Header Auditdescribe block that implements the automated CI check called for in #1773.New audit tests
Strict-Transport-Security,Permissions-Policy,X-Content-Type-Options,X-Frame-Options,Referrer-Policy) are emitted with default options.X-Content-Type-Optionsis alwaysnosniffregardless of custom HSTS/Permissions options.Referrer-Policyis alwaysstrict-origin-when-cross-origin.X-Frame-Optionsis alwaysSAMEORIGIN.max-ageis ≥ 31,536,000 s (1 year) by default, meeting Chrome/Firefox preload eligibility.paymentfeature-policy is'none'by default (no inadvertent Payment Request API exposure).applySecurityHeadersToResponseskips all headers whenheadersSentis true (missing test for this guard).