Repository navigation
test: automated test coverage (#1685) - #1884
Merged
github-actions[bot] merged 1 commit intoOct 22, 2026
Merged
github-actions[bot] merged 1 commit into
github-actions[bot] merged 1 commit into
Conversation
Re-lands the part of the reverted Smartdevs17#1703 squash that belongs to issue 1685 only. The remainder of the squash is re-landed by the other branches of the split, so this diff contains this issue's work exclusively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is the last of four pull requests that re-land the contents of the squash-merged PR #1703 one issue at a time.
#1703 was merged as a single commit (
5afe754) covering four unrelated issues. The companion pull request (the revert) undoes that squash so each issue can be merged on its own. This pull request restores only the part of #1703 that belongs to:What this changes
Seven new test suites that cover the behaviour introduced by the other three issues:
src/utils/__tests__/decimalAmount.test.tssrc/utils/__tests__/billingCycleMath.test.tsmonthlyEquivalent/yearlyEquivalentfor weekly, monthly and yearly cyclessrc/utils/__tests__/invoiceTotals.test.tscalculateInvoiceTotals: rounding, an itemised discount subtracted exactly once, and the discount clampsrc/services/__tests__/transactionConfirmation.test.tssrc/services/__tests__/rpcProvider.test.tssrc/store/_tests_/transactionQueueStore.test.tsbackend/shared/security/__tests__/outboundUrlGuard.test.tsMerge order
This is the fifth and last pull request in the split of #1703. It is based on
mainafter the revert pull request (#1880) and the #1683 (#1881), #1684 (#1882) and #1686 (#1883) pull requests were merged, so its diff contains the #1685 work and nothing else.The suites exercise the modules added by the #1683, #1684 and #1686 pull requests, so this pull request has to come last.
Merging it completes the split. After all five pull requests are merged,
mainis identical to its state before the split.The issues referenced above (#1683–#1686) have been deleted from the tracker, so they are referenced as plain text rather than with closing keywords.