Skip to content

XdgSurface::set_window_geometry should take i32 for x and y instead of u32 #485

Description

@tmccombs

A negatvie x, and y is perfectly acceptable for setting the window geometry. in fact it is desirable to do so when you want to include content above and/or to the left of the origin. In particular, if you are using client-side decoration, then you likely want your origin, to be the origin of inner content of the window, but set the window geometry to include the window decorations, which are likely above and to the left of your content.

And the current implementation of set_window_geometry just casts the u32s to i32s.

Note that the documentation for the set_window_geometry does not require the values to be non-negative.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions