Repository navigation
Conversation
chjpooh2002
approved these changes
Nov 9, 2026
Comment on lines
+13
to
+15
| public static UserDetailResult from(User user) { | ||
| return new UserDetailResult(user.getId(), user.getNickname(), user.getEmail(), user.getProfileImageUrl(), | ||
| SocialProvider.GOOGLE); |
Contributor
There was a problem hiding this comment.
나중에 네이버를 추가할 때 여기를 놓치면 네이버 회원도 GOOGLE로 내려가요. 주석 대신 이슈 번호를 단 TODO로 남겨주시면 좋겠습니다! 그리고 나중에 소셜 계정에서 읽으려면 user가 auth를 부르게 되는데, 지금은 auth가 user를 부르고 있어서(signUp, recordLogin) 그대로 하면 순환이 생겨요. 그때는 조합 서비스로 빼거나 auth 쪽에서 값을 넘기는 방향으로 가야 할 것 같습니다
|
|
||
| @GetMapping("/me") | ||
| public ResponseEntity<ApiResponse<UserDetailResponse>> getMe(@LoginUser Long userId) { | ||
| return ApiResponse.success(UserSuccessCode.USER_FOUND, UserDetailResponse.from(userQueryService.getDetail(userId))); |
Contributor
There was a problem hiding this comment.
(사소) 다른 컨트롤러처럼 서비스 결과를 변수로 받은 뒤 응답을 만드는 모양으로 맞춰주시면 좋겠습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
GET /api/v1/users/me(명세 5번)명세와 달라진 점
없음
테스트
전체
./gradlew build통과USER404_1COMMON401_1?userId=로 다른 회원을 지정해도 토큰의 회원 정보만 내려줌확인 체크리스트
./gradlew build통과리뷰어에게
loginType은 S1이 구글만이라GOOGLE로 고정했습니다. 제공자가 늘면 소셜 계정에서 읽도록 바꿉니다.UserQueryService에 각각 메서드를 추가해서, 병합 순서에 따라 작은 충돌이 날 수 있습니다.