Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates mashlib’s Solid ecosystem dependencies to newer major/minor versions and adjusts the webpack dev configuration to support producing both mashlib.js and mashlib.min.js during development/watch runs.
Changes:
- Bump mashlib version to
2.3.0and upgrade key runtime dependencies (solid-ui,solid-logic,solid-panes,pane-registry,rdflib). - Update webpack dev multi-config behavior by setting a distinct
devServer.portfor the secondary compiler config. - Refresh
package-lock.jsonto reflect the upgraded dependency graph (including new transitive packages).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
webpack.config.mjs |
Adds an explicit devServer.port override on the secondary dev config to satisfy webpack-cli’s unique-port requirement. |
package.json |
Bumps package version and upgrades core Solid-related dependencies. |
package-lock.json |
Updates the resolved dependency tree for the new dependency versions (notably including npm as a transitive dependency via solid-ui@4). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+59
to
+61
| "solid-logic": "^5.0.0", | ||
| "solid-panes": "^4.5.0", | ||
| "solid-ui": "^4.0.0" |
Comment on lines
+205
to
+213
| // webpack-cli requires a unique port per devServer config. | ||
| return [ | ||
| developmentBundle, | ||
| { | ||
| ...developmentBundle, | ||
| devServer: { | ||
| ...developmentBundle.devServer, | ||
| port: 8081 | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.