Staging version - #461
Closed
bourgeoa wants to merge 82 commits into
Closed
Conversation
…count SolidOS/solid-ui#769 Import design system and primitive styles
Bumps [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime) from 7.29.0 to 7.29.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.29.7/packages/babel-plugin-transform-runtime) --- updated-dependencies: - dependency-name: "@babel/plugin-transform-runtime" dependency-version: 7.29.7 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.107.1 to 5.107.2. - [Release notes](https://github.com/webpack/webpack/releases) - [Changelog](https://github.com/webpack/webpack/blob/main/CHANGELOG.md) - [Commits](webpack/webpack@v5.107.1...v5.107.2) --- updated-dependencies: - dependency-name: webpack dependency-version: 5.107.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 10.4.0 to 10.4.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.4.0...v10.4.1) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.4.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.29.5 to 7.29.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.29.7/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-version: 7.29.7 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [terser-webpack-plugin](https://github.com/webpack/minimizer-webpack-plugin) from 5.6.0 to 5.6.1. - [Release notes](https://github.com/webpack/minimizer-webpack-plugin/releases) - [Changelog](https://github.com/webpack/minimizer-webpack-plugin/blob/main/CHANGELOG.md) - [Commits](webpack/minimizer-webpack-plugin@v5.6.0...v5.6.1) --- updated-dependencies: - dependency-name: terser-webpack-plugin dependency-version: 5.6.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 7.0.2 to 7.0.3. - [Release notes](https://github.com/webpack/webpack-cli/releases) - [Changelog](https://github.com/webpack/webpack-cli/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@7.0.2...webpack-cli@7.0.3) --- updated-dependencies: - dependency-name: webpack-cli dependency-version: 7.0.3 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 8.59.3 to 8.60.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.60.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-version: 8.60.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [shell-quote](https://github.com/ljharb/shell-quote). Updates `shell-quote` from 1.8.3 to 1.8.4 - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.8.3...v1.8.4) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.8.4 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
SolidOS/solid-ui#780 Migrate solid-ui imports
…@3.1.3-0 pane-registry@3.1.2-0) (latest: rdflib@2.3.9)
fix browser style
…@3.1.3-9 pane-registry@3.1.2-2 solid-panes@4.4.2-4) (latest: rdflib@2.4.0)
…@3.1.3-10 pane-registry@3.1.2-2 solid-panes@4.4.2-4) (latest: rdflib@2.4.0)
New layout
…@3.1.3-13 pane-registry@3.1.2-2 solid-panes@4.4.2-4) (latest: rdflib@2.4.0)
…@3.1.3-13 pane-registry@3.1.2-2 solid-panes@4.4.2-4) (latest: rdflib@2.4.0)
…@3.1.3-13 pane-registry@3.1.2-2 solid-panes@4.4.2-4) (latest: rdflib@2.4.0)
Fix/webawesome location in webpack
…@3.1.3-13 pane-registry@3.1.2-2 solid-panes@4.4.2-5) (latest: rdflib@2.4.0)
remove dashboard, navbar and header menu do not need it
workspaceAlias added to web awesome
…@3.1.3-13 pane-registry@3.1.2-2 solid-panes@4.4.2-5) (latest: rdflib@2.4.0)
Contributor
There was a problem hiding this comment.
Pull request overview
Updates mashlib for staging SolidOS dependencies, migrates browser UI components, and adds staging CI and prerelease publishing.
Changes:
- Updates dependencies, webpack aliases, and bundling.
- Migrates browser templates and styles to Solid UI components.
- Adds staging dependency updates and prerelease publishing workflows.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Changes and final review comments |
|---|---|
webpack.config.mjs |
Updates aliases and development bundling. Provider subpath resolution can mix workspace and installed packages (moderate, 3 votes). Dev server still opens the removed /browse-test.html (moderate, 2 votes). |
static/browse.html |
Migrates the standalone browser UI to Solid UI provider and account components. |
static/browse-test.html |
Removes the obsolete test page, but the dev server still targets it and opens a 404 (moderate, 2 votes). |
src/styles/themes/light.css |
Removes duplicated typography variables. |
src/styles/themes/dark.css |
Removes duplicated typography variables. |
src/styles/mash.css |
Imports Solid UI theme and styles pane headers. |
src/index.ts |
Registers the Solid UI provider component. |
src/globals.ts |
Exposes Solid UI globals, but static import evaluation can occur before required globals are assigned (critical, 2 votes). |
src/databrowser.html |
Updates the application shell, but the height observer still queries the removed header ID, leaving the generated header unobserved (moderate, 4 votes). |
package.json |
Upgrades staging dependencies and metadata. |
.github/workflows/ci.yml |
The dependency-update job’s changes are not transferred to the build job, which checks out the original SHA and may publish stale dependencies (critical, 2 votes). |
Suppressed comments (2)
static/browse-test.html:1
- This file is removed, but
devServer.openstill points to/browse-test.htmlinwebpack.config.mjs:155. Starting webpack-dev-server will therefore open a 404 page instead of an available browser page; update the dev-server target (for example to/browse.html) or keep this fixture.
webpack.config.mjs:42 - Workspace mode is documented in
README.md:47-56as resolving sibling workspace trees, but this mapping now pointssolid-uiat a prebuilt../solid-ui/distand removes the siblingsolid-panesalias.build:workspaceonly builds mashlib, so a clean sibling checkout can fail because that dist is absent, while solid-panes source changes silently resolve from node_modules. Preserve the sibling mappings or add an explicit dependency-build step.
'solid-ui$': path.resolve('../solid-ui/dist/index.cjs.js'),
'solid-ui/components$': path.resolve('../solid-ui/dist/components/index.cjs.js'),
// See packageAliases: no prefix alias for 'solid-ui/components' — the
// shim files would shadow the correctly-externalized leaf entries.
'UI$': path.resolve('../solid-ui/dist/index.cjs.js'),
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| secrets: inherit | ||
|
|
||
| build: | ||
| needs: update-deps |
|
|
||
| <!-- Skip-navigation link (accessibility) --> | ||
| <a href="#MainContent" class="skip-link">Skip to main content</a> | ||
| <!-- Header — populated by solid-panes createHeader(), plus responsive menu toggle --> |
| // `window` at module-evaluation time, not after all imports have run. | ||
| import * as $rdf from 'rdflib' | ||
| import * as SolidLogic from 'solid-logic' | ||
| import * as UI from 'solid-ui' |
Comment on lines
+40
to
+41
| // See packageAliases: no prefix alias for 'solid-ui/components' — the | ||
| // shim files would shadow the correctly-externalized leaf entries. |
Comment on lines
+219
to
+221
| // Use a single devServer config for watch/dev runs to avoid duplicate port | ||
| // conflicts in webpack-dev-server. | ||
| return developmentBundle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.