security: codify GitHub WIF workflow allowlist - #1147
Open
think-back wants to merge 1 commit into
Open
think-back wants to merge 1 commit into
think-back wants to merge 1 commit into
Conversation
Record the exact GitHub workflow trust boundary already enforced online and keep the rotated staging database password under out-of-band ownership. Constraint: Trust must match immutable repository IDs and five exact workflow/ref pairs. Rejected: Repository-name-only trust | It permits every workflow in the repository to impersonate the shared deployer. Confidence: high Scope-risk: narrow Directive: Add any future deploy workflow and branch pair to allowed_workflows before expecting shared WIF authentication. Tested: terraform fmt -check -recursive deploy/gcp; terraform validate; targeted plan showed 0 add, 1 update, 0 destroy; desired WIF condition and mappings match live. Not-tested: terraform apply intentionally not run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Safety