Quick fix primary MAC lookup for shared MAC addresses - #413
Open
LambdaLightSource wants to merge 1 commit into
Open
LambdaLightSource wants to merge 1 commit into
LambdaLightSource wants to merge 1 commit into
Conversation
LambdaLightSource
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix primary MAC lookup for shared MAC addresses
Description
For NetBox 4.2+, MAC addresses are represented by
MACAddressobjects assigned to interfaces.When a physical interface and its VLAN interfaces legitimately share the same MAC address, selecting the primary MAC using only the MAC value is ambiguous because multiple
MACAddressobjects may exist with that value.This change scopes the lookup to both the current interface ID and MAC address, then assigns the matching
MACAddressobject's ID asprimary_mac_address.A regression test covers the shared-MAC case.
Validation:
tests/network.py: 4 passedruff check: passedruff format --check: passedgit diff --check: passedpy_compile: passedThis is intentionally submitted separately from #412 because the named VLAN parsing issue and the shared MAC primary address ambiguity have independent root causes.