Repository navigation
feat: report CodePush download size by version - #216
Merged
Merged
Conversation
floyd-soomgo
marked this pull request as ready for review
October 21, 2026 10:00
floyd-soomgo
force-pushed
the
feat/download-size-telemetry
branch
from
October 22, 2026 08:23
d11c06b to
4cb5e6d
Compare
The embedded bundle has no OTA label, so baseVersion falls back to the native app version. Native code built before this change returns no size, so downloadBytes is null rather than 0 to keep it distinguishable from a measured value.
The Android tests cover what the update manager reports, not the native module's callback wiring: the module cannot be constructed without a React context and native maps. The iOS tests call the module entry point directly.
floyd-soomgo
force-pushed
the
feat/download-size-telemetry
branch
from
October 22, 2026 08:46
4cb5e6d to
f82cb36
Compare
floyd-soomgo
force-pushed
the
feat/download-size-telemetry
branch
from
October 22, 2026 08:53
f82cb36 to
b9a3f06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow apps to record CodePush download file sizes by version without tracking download progress themselves.
onDownloadSuccess(targetVersion, { baseVersion, downloadBytes })now provides the version running before the update and the size of the final downloaded file used for the update. When running the embedded bundle, the base version is the native app version.nullfordownloadBytes.remotePackage.download()directly can read the same size fromlocalPackage.downloadBytes. It is not saved with the update, sogetCurrentPackage()andgetUpdateMetadata()do not return it.Validation
The implementation and JavaScript tests, native test coverage, and documentation are split into separate commits.