Repository navigation
Report the charge-current limit range a SPAN Drive declares - #236
Merged
Merged
Conversation
SpanEvseSnapshot gains charge_current_limit_minimum_a and charge_current_limit_maximum_a, the integer range the charge-current limit declares in its $format. The schema-1 adapter fills them from the same resolved ChargeLimitProperty.bounds that evse_charge_limit_payload enforces, so a control offers exactly the range a write accepts. Each side is None where the charger declares no limit or no format, leaves that side open, or declares a format declared_integer_bounds will not interpret. The flat schema declares no range and leaves both None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SpanEvseSnapshot.charge_current_limit_minimum_aandcharge_current_limit_maximum_a: the integer range a SPAN Drive declares for its user charge-current limit (firmware r202639 declares6:<commissioned maximum>),Nonewhere undeclared or uninterpretable. Schema-1 fills them from the same parsed range the write refusal (#233) enforces, so a consumer can offer exactly what a write will accept; schema-0 leaves themNone. Ships in the unpublished 3.8.0b2 / 1.4.0b4.Testing: full suite 2229 passed, 7 skipped, 9 xfailed; new tests cover the reference tree (6 and 32), no format, uninterpretable and inverted formats, open sides, and per-charger ranges, each shown failing before the change.