Repository navigation
Include the panel's masked device tree in diagnostics - #338
Merged
Merged
Conversation
span-panel-api 3.8.0b2 / schema-1 1.4.0b4 recaptured the schema-1 reference tree with ebus-panel-sim 0.9.0. The BESS meter is now published discharge-positive, opposite power-flows/battery (r202639's frame), and each charger declares its user charge-current limit (format 6:32) without publishing a value. Seven tests read the old tree; the integration reads the new one correctly, so the tests move. BESS telemetry: the capture-reading sign tests are scoped to r202639's frame, with the premise pinned (meter opposite the flow). The old frame is built by republishing the capture under an r202633 version string with the meter in the flow's sign, and keeps its own charging-reads- negative, two-sensors-agree and republish tests. EVSE charge limit: tests about a valued limit publish one, inside the ceiling, the way a charger does once a user sets it. Added coverage of the capture's own state (no user limit: the number shows the ceiling, bounded by it, available), of a limit set and then cleared through the transport, and of the pending write and the catalogued spelling with and without a user limit. Replay: captures_replay.replay sends a tree's empty value as Homie 5's 0x00 rather than a zero-length payload, which the library now reads as a clear, and the charge-limit tests' adapter replays through it.
…nimum to the maximum
Pins span-panel-api 3.8.0b2 and span-panel-api-schema-1 1.4.0b4, which carry the masked device-tree export the diagnostics now include, the declared charge-limit range the charge-limit number is bounded by, and the reference tree recaptured with ebus-panel-sim 0.9.0. span-panel-api-schema-0 stays 1.3.0b1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostics downloads now carry the panel's device tree as published, with serial numbers, device ids and site details masked by the library (span-panel-api 3.8.0b2 / span-panel-api-schema-1 1.4.0b4). When no tree is available,
device_treeis null anddevice_tree_unavailablesays why:flat_data_modelornot_described.Also in this branch: