Skip to content

Add support for multiple minion squads in enemy group. - #74

Closed
christianaustin85 wants to merge 3 commits into
SteelCompendium:mainfrom
christianaustin85:feat-67-multiple-minion-squads
Closed

christianaustin85 wants to merge 3 commits into
SteelCompendium:mainfrom
christianaustin85:feat-67-multiple-minion-squads

Conversation

@christianaustin85

Copy link
Copy Markdown

Removed validation logic that limited minion squads to 1.

@seedback seedback left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but shouldn't we allow one captain per minion squad?

Comment thread src/drawSteelAdmonition/EncounterData.ts
@scottTomaszewski

Copy link
Copy Markdown
Member

Thanks for this, and sorry for the slow reply — you had the right cap in your sights.

Multi-squad support has since landed on develop as part of the initiative tracker overhaul (closes #67; shipping in 7.0.0). It relaxes the same validation this PR removes, but it also had to move the shared Stamina pool from the enemy group onto each squad, add captain_of so a captain can name its squad, and keep one-squad encounters byte-identical — which is why it went in as a larger change rather than through this PR. This branch also targets main, which is release-only now; feature work goes to develop.

Closing as superseded. If you spot anything the landed version gets wrong for the Delian Tomb W1 case, please open an issue — happy to take a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants