Repository navigation
fix: VerifiedCreatorBadge verification date and method tooltip - #834
Merged
Kingsman-99 merged 1 commit intoSep 28, 2026
Merged
Kingsman-99 merged 1 commit into
Kingsman-99 merged 1 commit into
Conversation
…dCreatorBadge Closes Stellar-split#654
|
@therealbibson Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@therealbibson is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a contextual tooltip to
VerifiedCreatorBadgeso the checkmark is no longer information-free. Hovering or keyboard-focusing the badge now reveals how and when the creator was verified (e.g. "Verified via on-chain proof on January 15, 2024"), and screen readers announce the same text througharia-describedby.The verification metadata is read from the existing attestation store (
localStorage), so no new backend or contract surface is introduced.Related Issue
Closes #654
Changes
[MODIFY]
src/lib/attestation.tsmethod?: stringfield toCreatorAttestationso a verification method can be recorded and surfaced. Backward compatible — existing attestations without the field keep working and fall back to a generic label.[MODIFY]
src/components/VerifiedCreatorBadge.tsxgetAttestationin addition toisVerifiedCreator.role="tooltip"element with the formatted date and method, wired to the badge througharia-describedby.tabIndex={0}) with afocus-visiblering, and reveals the tooltip on hover and:focus-within.Intl.DateTimeFormat(month day, year).aria-describedby) when no verification date is available.[ADD]
src/__tests__/VerifiedCreatorBadge.test.tsxaria-describedbywiring; generic-method fallback; no-date → no tooltip; date formatting helper.Verification Results
role="tooltip"revealed bygroup-hover/group-focus-within, date viaIntl.DateTimeFormataria-describedbytabIndex={0}+focus-visiblering; tooltip id wired througharia-describedbyhasVerificationDateguard omits the tooltip and thearia-describedbyattributesrc/__tests__/VerifiedCreatorBadge.test.tsx