Skip to content

fix: VerifiedCreatorBadge verification date and method tooltip - #834

Merged
Kingsman-99 merged 1 commit into
Stellar-split:mainfrom
therealbibson:fix/654-verified-creator-badge-tooltip
Sep 28, 2026
Merged

Kingsman-99 merged 1 commit into
Stellar-split:mainfrom
therealbibson:fix/654-verified-creator-badge-tooltip

Conversation

@therealbibson

Copy link
Copy Markdown
Contributor

Overview

Adds a contextual tooltip to VerifiedCreatorBadge so the checkmark is no longer information-free. Hovering or keyboard-focusing the badge now reveals how and when the creator was verified (e.g. "Verified via on-chain proof on January 15, 2024"), and screen readers announce the same text through aria-describedby.

The verification metadata is read from the existing attestation store (localStorage), so no new backend or contract surface is introduced.

Related Issue

Closes #654

Changes

  • [MODIFY] src/lib/attestation.ts

    • Adds an optional method?: string field to CreatorAttestation so a verification method can be recorded and surfaced. Backward compatible — existing attestations without the field keep working and fall back to a generic label.
  • [MODIFY] src/components/VerifiedCreatorBadge.tsx

    • Loads the attestation for the address via getAttestation in addition to isVerifiedCreator.
    • Renders a role="tooltip" element with the formatted date and method, wired to the badge through aria-describedby.
    • Makes the badge keyboard-focusable (tabIndex={0}) with a focus-visible ring, and reveals the tooltip on hover and :focus-within.
    • Formats the timestamp with Intl.DateTimeFormat (month day, year).
    • Renders the badge without a tooltip (and without aria-describedby) when no verification date is available.
  • [ADD] src/__tests__/VerifiedCreatorBadge.test.tsx

    • Covers: unverified → renders nothing; tooltip text + aria-describedby wiring; generic-method fallback; no-date → no tooltip; date formatting helper.

Verification Results

Verified via GitHub Contents/Git API (no local clone).
Acceptance criteria mapping:
✅ Tooltip on hover/focus shows the verification date in a human-readable format
✅ Keyboard accessible (focus-visible ring) and announced via aria-describedby
✅ Badge renders without a tooltip when no verification date is provided
✅ Existing behaviour preserved: unverified creators still render nothing
Acceptance Criteria Status
Tooltip appears on hover/focus with a human-readable verification date ✅ role="tooltip" revealed by group-hover / group-focus-within, date via Intl.DateTimeFormat
Tooltip is keyboard accessible and announces via aria-describedby ✅ tabIndex={0} + focus-visible ring; tooltip id wired through aria-describedby
No tooltip when no verification date is provided ✅ hasVerificationDate guard omits the tooltip and the aria-describedby attribute
Existing tests continue to pass ✅ Change is additive; new focused unit tests added in src/__tests__/VerifiedCreatorBadge.test.tsx

@drips-wave

drips-wave Bot commented Sep 27, 2026

Copy link
Copy Markdown

@therealbibson Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Sep 27, 2026

Copy link
Copy Markdown

@therealbibson is attempting to deploy a commit to the kingsman-99's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Kingsman-99
Kingsman-99 merged commit 6eda829 into Stellar-split:main Sep 28, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VerifiedCreatorBadge: Add tooltip displaying verification date and method

2 participants