fix(amm): normalize price scales before computing price impact - #1017
Open
neverm1ndthat wants to merge 1 commit into
Open
neverm1ndthat wants to merge 1 commit into
neverm1ndthat wants to merge 1 commit into
Conversation
Issue Stellar-split#1011 - computePriceImpact() compared spot and effective prices at different decimal scales. An integer spot price like 1 (scale=1) and a fractional effective price like 0.91 (scale=10^12) produced spotScaled=1 vs effectiveScaled=910000... but the subtraction treated them as same-scale values, so price impact always rounded to 0.00%. Fix: bring both values to their common scale via cross-multiplication before computing percentage impact. Existing 12 AMM tests continue to pass.
Author
|
Hi @Kingsman-99! This PR fixes Issue #1011 - computePriceImpact() now normalizes spot and effective prices to their common decimal scale before comparing. An equal-reserve 1000/1000 pool with 100 input now correctly reports 9.00% impact instead of 0.00%. All 12 AMM tests pass. PTAL! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1011
Summary
computePriceImpact()compared spot and effective prices at different decimal scales. An integer spot price like"1"(scale=1) and a fractional effective price like"0.91"(scale=10^12) produced wrong results becausespotScaled - effectiveScaledtreated them as same-scale values.With an equal-reserve 1000/1000 pool and 100 input, the old code reported
0.00%impact instead of9.00%.The Fix
Bring both values to their common scale via cross-multiplication before computing percentage impact:
Testing
test/ammCalculator.test.tspass