Repository navigation
fix(amm): BigInt-safe ratio guard for estimateSwapOutput - #1018
Closed
neverm1ndthat wants to merge 1 commit into
Closed
neverm1ndthat wants to merge 1 commit into
neverm1ndthat wants to merge 1 commit into
Conversation
Issue Stellar-split#1007 - the maxRatio guard compared Number(amountIn)/Number(reserveIn). With values exceeding Number.MAX_VALUE, both become Infinity and Infinity/Infinity=NaN, silently bypassing the 30% liquidity ceiling. Fix: replace with ratioExceedsLimit() that cross-multiplies arbitrary-size BigInts against the numeric limit (parsed into numerator/denominator). Preserves existing behavior for finite callers and non-finite limit edge cases. Existing 12 AMM tests pass.
Author
|
Hi @Kingsman-99! This PR fixes Issue #1007 - the maxRatio guard now uses ratioExceedsLimit() with cross-multiplied BigInts instead of Number coercion. Values exceeding Number.MAX_VALUE (e.g. 10^400) can no longer Infinity/Infinity=NaN their way past the 30% guard. All 12 AMM tests pass. PTAL! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1007
Summary
The
maxRatioguard inestimateSwapOutput()usedNumber(amountIn) / Number(reserveIn). With values exceedingNumber.MAX_VALUE(e.g. 10^400), both becomeInfinityandInfinity / Infinity = NaN, which silently bypasses the 30% liquidity ceiling.The Fix
Replaced the
Numbercoercion withratioExceedsLimit():(numerator, denominator)BigIntsamount * denominator > reserve * numeratorTesting
test/ammCalculator.test.tspass