Repository navigation
feat(contracts): sc-hard-17/18/19/20 reentrancy guard, fixed-point ma… - #1460
Merged
ayomideadeniran merged 2 commits intoOct 2, 2026
Merged
Conversation
…th, rbac, contracterror - StellarDevHub#1363 sc-hard-17: zero-cost atomic reentrancy guard via soroban temporary storage mutex locks in lending_pool and smart_vault. nested reentrant calls revert with typed ReentrancyGuardTriggered error. - StellarDevHub#1364 sc-hard-18: replaced raw arithmetic with checked_add/checked_sub/ checked_mul/checked_div in continuous_bonding_curve and lending_pool. added fp18 module with 18-decimal fixed-point helpers and typed Overflow/Underflow/DivisionByZero error variants. - StellarDevHub#1365 sc-hard-19: introduced reusable access_control crate (300-399 range) with Admin/Operator/Guardian roles, timelocked role transfers, and atomic circuit-breaker pause/unpause. emergency withdrawals are exempt. - StellarDevHub#1366 sc-hard-20: eliminated all panic!("...") strings across every workspace contract. added documented #[contracterror] enums with partitioned discriminant ranges: lending_pool 1-99, smart_vault 100-199, continuous_bonding_curve 200-299, access_control 300-399, others 400+. affected: certificate_nft, oracle_aggregator, quadratic_voting, token_migration, sybil_resistance, freelance-platform/reputation_system, hello_world/freelance_platform, hello_world/reputation_system. - .gitignore: added .soroban/, *.wasm entries to exclude build artifacts. Closes StellarDevHub#1363, StellarDevHub#1364, StellarDevHub#1365, StellarDevHub#1366
|
@topboy192 is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@topboy192 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
pr under review, if i find any wrong implementation i will let you know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…th, rbac, contracterror
[SC-HARD-17] Zero-Cost Atomic Reentrancy Guard Trait for DeFi Protocols #1363 sc-hard-17: zero-cost atomic reentrancy guard via soroban temporary storage mutex locks in lending_pool and smart_vault. nested reentrant calls revert with typed ReentrancyGuardTriggered error.
[SC-HARD-18] Safe Fixed-Point Math & Invariant Bounds Engine #1364 sc-hard-18: replaced raw arithmetic with checked_add/checked_sub/ checked_mul/checked_div in continuous_bonding_curve and lending_pool. added fp18 module with 18-decimal fixed-point helpers and typed Overflow/Underflow/DivisionByZero error variants.
[SC-HARD-19] Universal Role-Based Access Control (RBAC) & Circuit Breaker Pause #1365 sc-hard-19: introduced reusable access_control crate (300-399 range) with Admin/Operator/Guardian roles, timelocked role transfers, and atomic circuit-breaker pause/unpause. emergency withdrawals are exempt.
[SC-HARD-20] Canonical
#[contracterror]Hierarchy across Workspace #1366 sc-hard-20: eliminated all panic!("...") strings across every workspace contract. added documented #[contracterror] enums with partitioned discriminant ranges: lending_pool 1-99, smart_vault 100-199, continuous_bonding_curve 200-299, access_control 300-399, others 400+. affected: certificate_nft, oracle_aggregator, quadratic_voting, token_migration, sybil_resistance, freelance-platform/reputation_system, hello_world/freelance_platform, hello_world/reputation_system..gitignore: added .soroban/, *.wasm entries to exclude build artifacts.
Closes #1363
close #1364
close #1365
close #1366