Conversation
- using qHash(englishName, 0)
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
Hello @gzotti! Thank you for the suggested improvement. |
|
How many objects in your ssystem.ini files and how many increases performance? |
|
I have started editing about 2 hours ago and wrote "EXPERIMENTAL DRAFT, ignore!" above. If VTune was right, 15-20% of SolarSystem::draw() goes into string equality tests with a solar system of around 11.000 objects. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
EXPERIMENTAL DRAFT, ignore!
VTune indicates that a considerable percentage of frame time is string comparison in the solar system, i.e., comparing englishName. This branch tries to mitigate the situation, first by using a hash-based ID.
Description
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: