Repository navigation
Fix the Windows file save encoding and a HarfBuzz use-after-free - #173
Merged
balazs-szucs merged 6 commits intoOct 19, 2026
Merged
Conversation
balazs-szucs
requested review from
ConnorYoh,
EthanHealy01,
Frooodle,
jbrunton96 and
reecebrowne
as code owners
October 18, 2026 16:15
|
Caution Review failedAn error occurred during the review process. Please try again later. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Priority: ➖ Normal Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
No pull request description was provided, so its relation to the changeset cannot be assessed. | Add a concise description that summarizes the Windows file-save fix, the HarfBuzz lifetime fix, and the related tests or workflow changes. |
-
Check name Status Explanation Title check The title clearly and concisely identifies both primary fixes: the Windows file-save encoding issue and the HarfBuzz use-after-free. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
CI annotation context is incomplete: annotation collection unavailable or limited
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: Stirling-Tools/JPDFium/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
931f3819-d2a1-40d6-a383-2eacaf732524
📒 Files selected for processing: 4
CHANGELOG.mdjpdfium/src/test/java/stirling/software/jpdfium/SaveEncodingNativeSmokeTest.javanative/bridge/src/jpdfium_document.cppnative/bridge/src/jpdfium_stub.cpp
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout: 23
- GitHub Check: build-natives (windows-arm64, windows-11-arm)
- GitHub Check: build-natives (windows-x64, windows-latest)
- GitHub Check: build-natives (linux-arm64, ubuntu-24.04-arm)
- GitHub Check: build-natives (darwin-x64, macos-15-intel)
- GitHub Check: CodeQL Analysis (c-cpp)
- GitHub Check: Restricted-env compat (no execstack + hermetic bundle)
- GitHub Check: Samples E2E Suite (All 88 Feature Samples)
- GitHub Check: build-natives (darwin-arm64, macos-14)
- GitHub Check: Build & Verify (Compilation) (macos-14)
- GitHub Check: Flaky-test guard (3× rerun)
- GitHub Check: prep-windows-icu
- GitHub Check: Samples E2E (88 features via RunAllSamples)
- GitHub Check: Build & Verify (Compilation) (windows-latest)
- GitHub Check: CodeQL Analysis (java-kotlin)
- GitHub Check: C++ - clang-tidy + cppcheck + clang-format
- GitHub Check: JMH Benchmarks (FFM Downcall Overhead Gate)
- GitHub Check: GraalVM Native Image Smoke & E2E Test (Linux x64)
- GitHub Check: Java - SpotBugs + Checkstyle + PMD + Spotless
- GitHub Check: Native bridge libFuzzer (ASan/UBSan, real PDFium)
- GitHub Check: CodeQL (c-cpp)
- GitHub Check: CodeQL (java-kotlin)
- GitHub Check: Corpus (generate + native)
- GitHub Check: CLI correctness & no-corruption tests
🧰 Additional context used
📚 Code guidelines: 1
.github/CODERABBIT_REVIEW.md — configured
📓 Path-based instructions: 4
Apply the native ownership, C ABI, C++23, engine integration, memory, and SIMD rules from .github/CODERABBIT_REVIEW.md.
⚙️ CodeRabbit configuration file
Files:
native/bridge/src/jpdfium_document.cppnative/bridge/src/jpdfium_stub.cpp
Enforce meaningful assertions, deterministic concurrency, failure-path cleanup, and explicit native/stub requirements.
⚙️ CodeRabbit configuration file
Files:
jpdfium/src/test/java/stirling/software/jpdfium/SaveEncodingNativeSmokeTest.java
Apply the Java 25 and FFM rules from .github/CODERABBIT_REVIEW.md.
⚙️ CodeRabbit configuration file
Files:
jpdfium/src/test/java/stirling/software/jpdfium/SaveEncodingNativeSmokeTest.java
Source excerpt: Use imports rather than package-qualified type names in method bodies and signatures.
📄 CodeRabbit inference engine (.github/CODERABBIT_REVIEW.md)
Files:
native/bridge/src/jpdfium_document.cppnative/bridge/src/jpdfium_stub.cppCHANGELOG.mdjpdfium/src/test/java/stirling/software/jpdfium/SaveEncodingNativeSmokeTest.java
balazs-szucs
force-pushed
the
fix/windows-binary-save
branch
from
October 18, 2026 16:24
3b83e51 to
c684956
Compare
balazs-szucs
force-pushed
the
fix/windows-binary-save
branch
from
October 18, 2026 16:47
c684956 to
4b8cb27
Compare
balazs-szucs
changed the title
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: Stirling-Tools/JPDFium/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
e617220b-962a-44fa-bba9-c54c33a6b249
📒 Files selected for processing: 3
CHANGELOG.mdjpdfium/src/test/java/stirling/software/jpdfium/SaveEncodingNativeSmokeTest.javanative/bridge/src/jpdfium_redact_pattern.cpp
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout: 24
- GitHub Check: prep-windows-icu
- GitHub Check: CodeQL (c-cpp)
- GitHub Check: CodeQL (java-kotlin)
- GitHub Check: Restricted-env compat (no execstack + hermetic bundle)
- GitHub Check: GraalVM Native Image Smoke & E2E Test (Linux x64)
- GitHub Check: Samples E2E Suite (All 88 Feature Samples)
- GitHub Check: Samples E2E (88 features via RunAllSamples)
- GitHub Check: Build & Verify (Compilation) (ubuntu-latest)
- GitHub Check: CodeQL Analysis (java-kotlin)
- GitHub Check: build-natives (darwin-arm64, macos-14)
- GitHub Check: build-natives (linux-arm64, ubuntu-24.04-arm)
- GitHub Check: Build & Verify (Compilation) (windows-latest)
- GitHub Check: JMH Benchmarks (FFM Downcall Overhead Gate)
- GitHub Check: Build & Verify (Compilation) (macos-14)
- GitHub Check: build-natives (darwin-x64, macos-15-intel)
- GitHub Check: build-natives (windows-x64, windows-latest)
- GitHub Check: CodeQL Analysis (c-cpp)
- GitHub Check: Flaky-test guard (3× rerun)
- GitHub Check: build-natives (windows-arm64, windows-11-arm)
- GitHub Check: Corpus (generate + native)
- GitHub Check: Native bridge libFuzzer (ASan/UBSan, real PDFium)
- GitHub Check: C++ - clang-tidy + cppcheck + clang-format
- GitHub Check: CLI correctness & no-corruption tests
- GitHub Check: Java - SpotBugs + Checkstyle + PMD + Spotless
🧰 Additional context used
📚 Code guidelines: 1
.github/CODERABBIT_REVIEW.md — configured
📓 Path-based instructions: 4
Apply the native ownership, C ABI, C++23, engine integration, memory, and SIMD rules from .github/CODERABBIT_REVIEW.md.
⚙️ CodeRabbit configuration file
Files:
native/bridge/src/jpdfium_redact_pattern.cpp
Enforce meaningful assertions, deterministic concurrency, failure-path cleanup, and explicit native/stub requirements.
⚙️ CodeRabbit configuration file
Files:
jpdfium/src/test/java/stirling/software/jpdfium/SaveEncodingNativeSmokeTest.java
Apply the Java 25 and FFM rules from .github/CODERABBIT_REVIEW.md.
⚙️ CodeRabbit configuration file
Files:
jpdfium/src/test/java/stirling/software/jpdfium/SaveEncodingNativeSmokeTest.java
Source excerpt: Use imports rather than package-qualified type names in method bodies and signatures.
📄 CodeRabbit inference engine (.github/CODERABBIT_REVIEW.md)
Files:
CHANGELOG.mdjpdfium/src/test/java/stirling/software/jpdfium/SaveEncodingNativeSmokeTest.javanative/bridge/src/jpdfium_redact_pattern.cpp
🔇 Additional comments: 1
native/bridge/src/jpdfium_redact_pattern.cpp: 1
962-964: LGTM!Also applies to: 966-966
Collaborator
Author
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Frooodle
approved these changes
Oct 19, 2026
Collaborator
Author
|
This is not synced with upstream main + I wanna port freebsd flaky fix again here. I am testing the CI workflow on my fork. It annoys the hell out of me how the BSD infra is setup because there no obvious easy way to make the CI non-flaky. But alas, i will try to do some magic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.