[balazs-szucs]

No description provided.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: Stirling-Tools/JPDFium/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 94dab323-46a0-447a-a4fc-6e390b05b219

📥 Commits

Reviewing files that changed from the base of the PR and between 7d26671 and 6ea7e10.

📒 Files selected for processing: 2

• .github/workflows/release.yml
• .github/workflows/snapshot.yml

📝 Summary

Summary by CodeRabbit

• Build Compatibility
  • Pinned macOS builds now use PDF components from the platform’s core native bundle, improving consistency in bundled PDF support. This change applies only to pinned macOS builds; other platforms and source-build configurations are unchanged.

The snapshot workflow now replaces selected PDFium component dylibs in the pinned libvips bundle on macOS. Other platforms and non-pinned source-build paths do not use this substitution.

Changes: macOS PDFium bundle substitution

Layer / File(s)	Summary
Pinned macOS dylib substitution .github/workflows/snapshot.yml	For darwin-* platforms, the pinned libvips path copies PDFium, allocator, zlib, ICU, Skia, Abseil, and HarfBuzz dylibs from core natives into the vips distribution.

Suggested reviewers: frooodle

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: 🟡 Moderate · up to 7d266

The pinned macOS vips bundle cannot be produced until the allocator files are expanded from the core natives directory. Fix this before merging.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The pull request has no description. It does not include the required change summary, checklist responses, testing details, or native and library change information.	Add a description that follows the repository template. Document what changed and why, complete the applicable checklist items, and provide testing results and any required native or API change details.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: refreshing the vips bundle's PDFium components from the core natives.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Repository: Stirling-Tools/JPDFium/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 6629701d-0b93-4afe-ae9d-35f69b457e23

📥 Commits

Reviewing files that changed from the base of the PR and between 6cdae8b and 7d26671.

📒 Files selected for processing: 1

• .github/workflows/snapshot.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Review details

⏰ Context from checks skipped due to timeout: 43

• GitHub Check: Gradle lockfile freshness
• GitHub Check: Outdated dependencies report
• GitHub Check: FFM layout vs pinned PDFium headers
• GitHub Check: Module descriptor integrity
• GitHub Check: Shellcheck (scripts + native/*.sh)
• GitHub Check: build-natives (linux-x64, ubuntu-latest)
• GitHub Check: build-natives (windows-arm64, windows-11-arm)
• GitHub Check: Public API compatibility (japicmp vs last release)
• GitHub Check: build-natives (darwin-arm64, macos-14)
• GitHub Check: Javadoc builds cleanly
• GitHub Check: build-natives (windows-x64, windows-latest)
• GitHub Check: build-natives (linux-arm64, ubuntu-24.04-arm)
• GitHub Check: build-natives (darwin-x64, macos-15-intel)
• GitHub Check: C++ - clang-tidy + cppcheck + clang-format
• GitHub Check: CodeQL (java-kotlin)
• GitHub Check: OSV vulnerability scan
• GitHub Check: Java - SpotBugs + Checkstyle + PMD + Spotless
• GitHub Check: Corpus (generate + native)
• GitHub Check: prep-windows-icu
• GitHub Check: CodeQL (c-cpp)
• GitHub Check: Publish Maven Dry Run
• GitHub Check: Build & Verify (Compilation) (ubuntu-latest)
• GitHub Check: Flaky-test guard (3× rerun)
• GitHub Check: CodeQL Analysis (c-cpp)
• GitHub Check: Musl Native Detection (Alpine)
• GitHub Check: Corpus + integration e2e
• GitHub Check: CodeQL Analysis (java-kotlin)
• GitHub Check: Samples E2E Suite (All 88 Feature Samples)
• GitHub Check: Concurrency Stress Tests (Linux x64)
• GitHub Check: README Quick Start Example (Linux x64)
• GitHub Check: JMH Benchmarks (FFM Downcall Overhead Gate)
• GitHub Check: Build & Verify (Compilation) (windows-latest)
• GitHub Check: Build & Verify (Compilation) (macos-14)
• GitHub Check: Robustness, Leak & Determinism Tests (Linux x64)
• GitHub Check: Natural System Libvips & Downstream Integration (Linux x64)
• GitHub Check: GraalVM Native Image Smoke & E2E Test (Linux x64)
• GitHub Check: Bundle verify (symbols, RPATH, linkage, sizes)
• GitHub Check: Native bridge libFuzzer (ASan/UBSan, real PDFium)
• GitHub Check: Samples E2E (88 features via RunAllSamples)
• GitHub Check: CLI correctness & no-corruption tests
• GitHub Check: Unit & Integration E2E Tests (Linux x64)
• GitHub Check: Restricted-env compat (no execstack + hermetic bundle)
• GitHub Check: JaCoCo coverage (non-blocking ratchet)

🧰 Additional context used

🪛 zizmor (1.30.1)

.github/workflows/snapshot.yml

[warning] 720-720: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)