Repository navigation
fix(settings): explain compatibility-blocked settings - #186
Merged
Merged
Conversation
Pin the diff algorithm to myers so a user-level diff.algorithm does not realign unrelated patches. Skip Properties/AssemblyInfo.cs, which bootstrap rewrites only under build/. Stop bootstrap from copying sources/assets into the repository root, and ignore that directory.
Bump the shader compatibility report to schema 2 and write featureMods, a list of display names per disabled feature. The runtime reads them directly and treats older reports as stale, falling back to the mods that ship shaders or render hooks.
Mark blocked rows as unavailable with a plain-language hover, and list them under the mod that caused the block. Keep the technical reason in the hover and warn when the report comes from an older Optimum. Replace the scrolling list with a GuiElementContainer so controls scroll with their labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166
The Extra tab now shows which settings are blocked by the compatibility scan and why. Blocked rows are marked "(unavailable)" and keep their saved value, so the preference applies again once the conflict is gone.
What changed:
featureMods, a list of mod display names per disabled feature, so the UI no longer parses thefeatureSourcesstrings.GuiElementContainer, which fixes the scrolling defect where labels moved but selectors and controls stayed in place.extract-patches.shandregen-one-patch.ps1pin the myers diff algorithm and skipProperties/AssemblyInfo.cs, and bootstrap no longer copiessources/assetsinto the repository root.Testing:
Optimum.Tests806 passed, 34 skipped. Launcher 39, Cli 25, Bootstrap.Core 220 and Installer 104 passed.make check-patches(70 applied, 52 Cecil, 0 conflicts),make check-shadersandmake check-compatpassed.Known gap, not part of this PR: the scanner does not read
modPathsfromclientsettings.json, so mods installed there are not scanned.