Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When mod updates are detected on startup,
GlobalModUpdateCheckerdisplays an actionable notification banner ("The selected Installation has X Mods with updates available") with a "View updates" action. Because actionable notifications have no auto-dismiss timeout, the notice remained on screen indefinitely even after the player navigated to Manage Mods and completed "Update all" or updated the individual mods.This change:
options.onCreatedandoptions.idtoNotificationOptionsand introducesresolveNotification(id: string, resolvedWith?: string)toNotificationsContextto dismiss banners and mark records resolved in the Activity Center.modUpdateNotices.ts) tracking the active startup mod update notice per installation.useBulkUpdateModsand leaves no remaining updatable mods.useManageInstalledModsfinishes scanning and confirms zero updatable mods remain (covering single mod updates, manual installations, and deletions).Type
Checklist
dev, notmain.npm run typecheckpasses.npm run lint:cipasses.npm run format:checkpasses.npm run test:coveragepasses, coverage at or above the floor invitest.config.ts.npm run build:unpackpasses.Testing
npm run typecheck: passed with zero errors across node, web, and tests.npm run lint:ci: passed with zero errors across oxlint and eslint.npm run format:check: passed with 100% formatted.npm run test:coverage: passed with 305 test files (1927 tests passed, 2 skipped) with coverage floors exceeded:npm run build:unpack: passed with unpacked Linux binary generated indist/linux-unpacked.tests/renderer/modUpdateNotices.test.tsfor recording, retrieving, and resolving startup notice entries.tests/renderer-dom/activityCenter.test.tsxforoptions.onCreated,options.id, andresolveNotification.tests/renderer-dom/globalModUpdateChecker.test.tsxverifying startup notice tracking and dismissal upon resolution.Related issues
Fixes #752