Repository navigation
feat(openapi): declare admin auth and the real version - #399
Merged
Ashborne267 merged 3 commits intoOct 27, 2026
Merged
Conversation
|
@Sensei-Victor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #357
Summary of Changes
package.jsonat startup instead of hardcoding1.0.0.components.securitySchemes:adminAddress(x-admin-address)adminSignature(x-admin-signature)adminTimestamp(x-admin-timestamp)[{ adminAddress: [], adminSignature: [], adminTimestamp: [] }]) on all admin endpoints (/ngo-applications/stats,/ngo-applications,/ngo-applications/:id,/ngo-applications/:id/approve,/ngo-applications/:id/reject,/ngos/all, and/admin/ngos/:id).onRoutehook check to ensure any route usingrequireAdminSignatureautomatically inherits the security scheme in OpenAPI documentation.Health,NGOs,Donors,Streams,Impact,NGO Applications,Indexer,Metrics).test/openapi.test.tsasserting spec version, security schemes, endpoint protections, and tags.Testing Performed
npm run lint/npx eslint .— code conforms cleanly to project ESLint standards without warnings.npm run typecheck— TypeScript check passed with 0 errors.npm test— all test suites including unit, integration, and OpenAPI assertions passed cleanly.