Repository navigation
Conversation
|
Hi @PHADAR6, thanks for resubmitting this. I went through the diff and the code in this PR is clean. Before we can merge, there is something important on your side. Your fork (PHADAR6/streamgive-backend) still contains the malware that was in your earlier PRs #201 and #204. Its main has a hidden payload in api.js and eslint.config.js, and the dev, build and start scripts in package.json run api.js. The old feat/issue-107-... and feat/issue-129-... branches have it too. This is the PolinRider malware. It usually spreads silently from an infected computer into every repo you commit to, so I think it's very likely still on your machine, and it can also steal tokens and keys. I don't think you did anything on purpose, but please: Scan and clean your computer. Check for a .vscode/tasks.json in your projects, and for api.js or branch_structure.json in the root of repos you work on. If you aren't sure the machine is clean, reinstalling the OS is the safe option. |
|
@Ashborne267 — this PR is ready for another review. I resolved the merge conflicts with the main branch (pushed 4981868). |
|
@PHADAR6 I'm putting this PR on hold, and #424 too, until the points below are done. I checked your fork again today (2026-10-30) and nothing has changed since my earlier comment. Your fork's main (862a17a) still contains the malware: a hidden api.js, a scrambled eslint.config.js, and dev, build and start in package.json that run api.js. Scan and clean your computer. If you aren't sure it's clean, reinstall the OS. You're welcome to come back with a fresh PR once your machine is clean. If I don't hear back within 3 days (by 2026-11-02), I'll close both PRs and release the issues so someone else can take them. |
Overview
This PR extends the admin
GET /ngo-applicationslist so reviewers can search applications by name or email and narrow results by submission date, in addition to the existing status filter.Related Issue
Closes #
Changes
🔎 Admin Applications List Filters
[MODIFY]
src/routes/ngoApplications.tssearchquery param matching applicant name / email.submittedAfterandsubmittedBeforequery params to bound the submission date range.[MODIFY]
test/routes/ngoApplications.test.tsVerification Results
search(name/email) param on admin listngoApplications.tssubmittedAfter/submittedBeforeparamsngoApplications.tsngoApplications.test.tstest/routes/ngoApplications.test.tsCloses #129