Blank Version column for un-versioned Change Log entries - #7134
Merged
Conversation
…nferring one PR #7116's Change Log table conversion inferred a version number for entries with no explicit version in the source, counting backward from the nearest known version. When there were more un-versioned entries than room below the first explicit version, the inference clamped at the floor and reused it, making genuinely separate, years-apart changes look like they shipped in the same release (flagged in review on #7116 across 61 files). Reverts that inference: rows that had no explicit version in the source now leave the Version column blank instead of guessing. Excludes slack.md's and darktrace.md's legitimate duplicate version labels, which were explicit in the source and preserved verbatim, not inferred. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
amee-sumo
requested review from
JV0812,
kimsauce and
mafsumo
as code owners
September 11, 2026 09:42
Extends the previous fix on this branch beyond just the colliding-version cases: every row whose original bullet-list entry had no explicit version now leaves the Version column blank, across all converted integration docs except the eight files whose inferred versions were reviewed and kept (LaunchDarkly, AWS Lambda, DFIR-IRIS, Google Cloud Functions, Microsoft Graph Security, CrowdStrike Falcon Sandbox, Azure AD, Mimecast V2). Also corrects 8 rows (cisco-meraki.md, google-chat.md, trend-micro-deep-security.md, urlhaus-abuse.md) that the previous commit on this branch blanked by mistake: those version numbers were genuinely explicit and duplicated in the original source, not inference artifacts, so they're restored to their real values. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 tasks
JV0812
approved these changes
Sep 11, 2026
JV0812
left a comment
Collaborator
There was a problem hiding this comment.
Verified the fix logic across a broad sample, including every file with a duplicate version label in the pre-PR source (61 files):
slack.mdanddarktrace.md— confirmed their genuine duplicate labels (v1.10x2,v1.5x2) are explicit in source and left untouched, exactly as described.crowdstrike-falcon.mdandatlassian-jira.md— confirmed the actual bug pattern: multiple entries years apart (2019–2023) were all clamped tov1.0, now correctly blanked instead of guessed.cisco-meraki.md,trend-micro-deep-security.md,urlhaus-abuse.md,google-chat.md— same pattern holds: legitimate explicit duplicates preserved, only the trailing inferred rows blanked.mimecast.md,logrhythm.md,aws-security-hub.md,chronicle.md— single trailing inferred row blanked as expected, no regressions from my earlier #7116 review.
One note: the PR description says "60 files changed... 160 rows blanked," but the actual diff touches 325 files with 551 blanked rows (likely an undercount from gh's 100-file API cap when drafting the description). Doesn't affect the correctness of the fix — just flagging so the description isn't misleading for future reference.
CI is green across the board. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Follow-up to #7116. That PR's Change Log table conversion inferred a version number for entries with no explicit version in the source, counting backward from the nearest known version. When there were more un-versioned entries than room below the first explicit version, the inference clamped at the floor and reused it, making genuinely separate, years-apart changes look like they shipped in the same release. Kim flagged this in review on #7116, across 61 files, after that PR had already merged.
This PR reverts that inference: any row that had no explicit version in the source now leaves the Version column blank instead of guessing.
slack.md's anddarktrace.md's legitimate duplicate version labels are left untouched, since those were explicit in the source and preserved verbatim, not inferred — 60 files changed in total, 160 rows blanked.Select the type of change
Ticket (if applicable)
N/A