Skip to content

Match the map pool to VALORANT 13.08 - #416

Merged
SunkenInTime merged 1 commit into
mainfrom
t3/map-pool-413
Nov 1, 2026
Merged

SunkenInTime merged 1 commit into
mainfrom
t3/map-pool-413

Conversation

@SunkenInTime

@SunkenInTime SunkenInTime commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

Pick a map before and after, with Out of rotation open

ci: test

Fixes #413. Pick a map still showed the pool from before Act 6, so a player opening New Strategy saw Ascent and Split up front and had to open Out of rotation to find Bind and Corrode. The screenshot in the issue is exactly that list.

Riot's 13.08 notes (Oct 13, 2026) say "BIND and CORRODE are IN the COMPETITIVE and DEATHMATCH queues" and "ASCENT and SPLIT are OUT". The 13.09 notes (Oct 27) don't mention the pool. The live pool is Abyss, Bind, Corrode, Haven, Lotus, Summit, Sunset. Riot publishes no 13.07 notes. We already have art for all of them, and Corrode's art got its 13.08 layout on Oct 13.

Maps.availableMaps and Maps.outofplayMaps are read by two widgets and nothing else: the create strategy dialog and the map selector in the editor. Both follow the lists without a code change, so the fix is the two lists.

Saved strategies don't change. Neither list is read on any save, load, import, export or sync path. Hive stores the MapValue by its own id, .ica files and cloud rows store the name from Maps.mapNames, and the server checks against its own list in convex/lib/maps.ts. None of those moved.

Seen in a driver build on Windows, old and new builds from one checkout with only maps.dart changed:

  • Both lists render as in the picture, and the editor's map selector lists the new pool. Picking Corrode from the dialog opens a strategy on it.
  • I made strategies on Ascent, Split, Bind and Corrode with the old build, then opened that library with the new one. All four open on their own map. The two Ascent agents are at the coordinates they were saved at, and the screen matches the old build pixel for pixel.

map_pool_test.dart fails if a map ends up in neither list, which would leave it unpickable. It failed when I took Split out. web_beta_library_test.dart tapped the Ascent tile, which is now behind Out of rotation, so it takes the first map in the pool and won't break at the next rotation. tool/drive/scripts/pick-a-map.json is the script behind the pictures.

Not covered: web. It renders the same dialog from the same lists, but I didn't open it in a browser. The pool is compiled in, so desktop users only get this with a desktop release. Web gets it on merge.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Updates the map pickers for the stated VALORANT 13.08 pool.

  • Map pickers put Bind and Corrode up front and move Ascent and Split out.

Review checks were source-only. Tests were not run, and no UI capture was made: this checkout has no built app, and the supplied driver targets Windows. The live game pool was not independently checked. The author’s reported desktop checks support the change; browser testing remains unverified.

Reviews (1) · Last reviewed commit: "Match the map pool to VALORANT 13.08" · Reviewed by Greptile

Summary by CodeRabbit

  • Map Pool Updates
    • Bind and Corrode are now available.
    • Ascent and Split are now out of play.
    • The available map pool also includes Haven, Lotus, Sunset, and Summit. Maps out of play also include Breeze, Fracture, Icebox, and Pearl.

Riot's 13.08 notes put Bind and Corrode in and take Ascent and Split out;
13.09 leaves the pool alone. Pick a map still offered the old pool (#413).
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b47e3750-d6cc-45c2-9133-b5dcdf908a24
Commits

Reviewing files that changed from the base of the PR and between 9e799b1 and b7ed4e0.

Files selected for processing: 4
  • lib/const/maps.dart
  • test/map_pool_test.dart
  • test/widgets/web_beta_library_test.dart
  • tool/drive/scripts/pick-a-map.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The available and out-of-play map lists are updated. A test checks that both lists contain every map value. Widget tests select a map from the available list, and a UI automation sequence exercises strategy creation and map selection.

Changes: Map pool and selection flow

Layer / File(s) Summary
Update map pool and selection coverage
lib/const/maps.dart, test/map_pool_test.dart, test/widgets/web_beta_library_test.dart, tool/drive/scripts/pick-a-map.json
The available and out-of-play lists exchange Ascent and Split for Bind and Corrode. A test checks that the lists cover all map values. Widget tests find a strategy tile for the first available map. The automation script captures strategy creation and map selection steps.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: Minimal · up to b7ed4

The map-pool update and related selection coverage are mergeable with no confirmed current-head defect.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating the map pool to match VALORANT 13.08.
Linked Issues check Passed Issue #413 requires the default map list to match the current game pool. Maps.availableMaps contains Abyss, Bind, Corrode, Haven, Lotus, Summit, and Sunset. Maps.outofplayMaps contains Ascent, Bre…
Out of Scope Changes check Passed The changes stay within issue #413. The map list change implements the requested pool update. map_pool_test.dart checks list completeness. web_beta_library_test.dart removes a stale Ascent-specifi…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Linked Issues check

Explanation

Issue #413 requires the default map list to match the current game pool. Maps.availableMaps contains Abyss, Bind, Corrode, Haven, Lotus, Summit, and Sunset. Maps.outofplayMaps contains Ascent, Breeze, Fracture, Icebox, Pearl, and Split. The map_pool_test.dart test verifies that every MapValue appears in exactly one list. The updated web-beta tests select the first available map instead of assuming Ascent is in the pool.

Full details: Out of Scope Changes check

Explanation

The changes stay within issue #413. The map list change implements the requested pool update. map_pool_test.dart checks list completeness. web_beta_library_test.dart removes a stale Ascent-specific test assumption. pick-a-map.json supports verification of the changed map-picker flow. No unrelated product behavior is changed.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@SunkenInTime
SunkenInTime merged commit 94e009e into main Nov 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map pool in pick a map window not updated

1 participant