Repository navigation
Match the map pool to VALORANT 13.08 - #416
Conversation
Riot's 13.08 notes put Bind and Corrode in and take Ascent and Split out; 13.09 leaves the pool alone. Pick a map still offered the old pool (#413).
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update map pool and selection coverage lib/const/maps.dart, test/map_pool_test.dart, test/widgets/web_beta_library_test.dart, tool/drive/scripts/pick-a-map.json |
The available and out-of-play lists exchange Ascent and Split for Bind and Corrode. A test checks that the lists cover all map values. Widget tests find a strategy tile for the first available map. The automation script captures strategy creation and map selection steps. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix · Severity of issue fixed: Medium
Merge Risk: 
Minimal · up to b7ed4
-
The map-pool update and related selection coverage are mergeable with no confirmed current-head defect.
Pre-merge checks: 
5
-
Full details: Linked Issues check
-
Explanation
Issue
#413requires the default map list to match the current game pool.Maps.availableMapscontains Abyss, Bind, Corrode, Haven, Lotus, Summit, and Sunset.Maps.outofplayMapscontains Ascent, Breeze, Fracture, Icebox, Pearl, and Split. Themap_pool_test.darttest verifies that everyMapValueappears in exactly one list. The updated web-beta tests select the first available map instead of assuming Ascent is in the pool.
Full details: Out of Scope Changes check
-
Explanation
The changes stay within issue
#413. The map list change implements the requested pool update.map_pool_test.dartchecks list completeness.web_beta_library_test.dartremoves a stale Ascent-specific test assumption.pick-a-map.jsonsupports verification of the changed map-picker flow. No unrelated product behavior is changed.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
ci: test
Fixes #413. Pick a map still showed the pool from before Act 6, so a player opening New Strategy saw Ascent and Split up front and had to open Out of rotation to find Bind and Corrode. The screenshot in the issue is exactly that list.
Riot's 13.08 notes (Oct 13, 2026) say "BIND and CORRODE are IN the COMPETITIVE and DEATHMATCH queues" and "ASCENT and SPLIT are OUT". The 13.09 notes (Oct 27) don't mention the pool. The live pool is Abyss, Bind, Corrode, Haven, Lotus, Summit, Sunset. Riot publishes no 13.07 notes. We already have art for all of them, and Corrode's art got its 13.08 layout on Oct 13.
Maps.availableMapsandMaps.outofplayMapsare read by two widgets and nothing else: the create strategy dialog and the map selector in the editor. Both follow the lists without a code change, so the fix is the two lists.Saved strategies don't change. Neither list is read on any save, load, import, export or sync path. Hive stores the
MapValueby its own id,.icafiles and cloud rows store the name fromMaps.mapNames, and the server checks against its own list inconvex/lib/maps.ts. None of those moved.Seen in a driver build on Windows, old and new builds from one checkout with only
maps.dartchanged:map_pool_test.dartfails if a map ends up in neither list, which would leave it unpickable. It failed when I took Split out.web_beta_library_test.darttapped the Ascent tile, which is now behind Out of rotation, so it takes the first map in the pool and won't break at the next rotation.tool/drive/scripts/pick-a-map.jsonis the script behind the pictures.Not covered: web. It renders the same dialog from the same lists, but I didn't open it in a browser. The pool is compiled in, so desktop users only get this with a desktop release. Web gets it on merge.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Updates the map pickers for the stated VALORANT 13.08 pool.
Review checks were source-only. Tests were not run, and no UI capture was made: this checkout has no built app, and the supplied driver targets Windows. The live game pool was not independently checked. The author’s reported desktop checks support the change; browser testing remains unverified.
Reviews (1) · Last reviewed commit: "Match the map pool to VALORANT 13.08" · Reviewed by Greptile
Summary by CodeRabbit