Repository navigation
Say what Autosave does for cloud strategies - #422
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
greptile-apps
Bot
dismissed
their stale review
November 1, 2026 00:10
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: skip
Autosave's description promised "When off, Icarus will ask before you leave unsaved work." That's untrue for a cloud strategy. Cloud strategies sync whatever the toggle says, and the toggle never touches them (
refreshAutosaveSchedulingreturns early for cloud). The text now says which strategies the setting covers:"This device" is the phrase the app's sync messages already use. The other descriptions in Settings start with a plain verb, so this one does too. I didn't write "always sync", because rejected or paused work can need the user, and the app shouldn't promise more than it does.
How far this got
I tested each sentence in a Windows driver build with Autosave turned off. The last sentence's wording changed after those runs, so behaviour was checked on the earlier commit, and the picture above comes from this head.
On this device. I added an agent to a local strategy, waited past the 15 seconds and pressed Home. "Save changes?" came up.
Cloud. Signed in on the dev deployment, I added an agent to a cloud strategy. The queue emptied in under two seconds, and Home went straight to the library with no prompt. A fresh instance with an empty store then read the strategy back from the server with both agents.
The before picture is a driver build of main at the same window size. At that width the new text takes two lines.
Not covered
The web build shows this same setting, where the toggle does nothing because the web has no local library. The new text is still true there, but I didn't look at it in a browser. Hiding the toggle on web would be a separate change.
The wording change appears safe to merge.Summary
Updates the Autosave description in
settings_tab.dartto distinguish saves on this device from cloud sync.Reviews (2) · Last reviewed commit: "Keep the Autosave text from promising de..." · Reviewed by Greptile