Repository navigation
fix(linux): preserve PipeWire startup history for portal recovery - #6102
Draft
ReenigneArcher wants to merge 1 commit into
Draft
ReenigneArcher wants to merge 1 commit into
ReenigneArcher wants to merge 1 commit into
Conversation
Member
Author
|
Bundle ReportBundle size has no change ✅ |
2 tasks done
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6102 +/- ##
==========================================
+ Coverage 50.80% 50.98% +0.17%
==========================================
Files 148 148
Lines 32413 32446 +33
Branches 13701 13711 +10
==========================================
+ Hits 16469 16544 +75
- Misses 12362 14227 +1865
+ Partials 3582 1675 -1907
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 48 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #6102 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: AppImage-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After an established portal stream transitions
streaming -> paused -> error, checking only the previous state mistakes it for a stream that never started. Depending on when the capture thread handles the pause, this permanently disablesmaxFrameratenegotiation for subsequent streams until Sunshine restarts.Track an atomic
has_streamedflag for each PipeWire connection and use it to restrict the existing fallback to streams that have never reachedstreaming. Reset the flag for a new connection, and retain it across pauses, errors, and disconnects. The tests exercise the real PipeWire callback and portal handler without a compositor or portal session.Screenshot
Issues Fixed or Closed
Prevents the display-disconnect sequence in the failure log from permanently disabling
maxFrameratenegotiation. The same state-handling defect also exists in stable v2026.914.233613. Reporter testing has been requested to verify recovery on the affected KDE/NVIDIA setup.Roadmap Issues
Testing
previous_statecondition makesPortalRetainsMaxFramerateAfterAnEstablishedStreamFailsfail; the never-started fallback test still passes. Both pass with the fix.sunshineandtest_sunshinebuilds passed withBUILD_WERROR=ON, portal, KWin, Wayland, VA-API, DRM and Vulkan enabled; CUDA and tray disabled.Configurations/AudioTest,MouseInputs/MouseHIDTest,EncoderVariants/EncoderTest) failed platform setup because the container has no graphical capture session; those 11 tests were excluded from the runnable pass. The remaining skips cover Windows-only support, an unavailable scoped network interface, and disabled tray support.uv sync --locked,uv run --locked lb-update-clang-format, andgit diff --check: passed. No unrelated formatting changes.Type of Change
Checklist
AI Usage
See our AI usage policy.