Repository navigation
Fix the macOS flake of extent_separation.cpp: fail the wrong copy without a loop - #126
Merged
Merged
Conversation
…terexample needs no search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the macOS flake of
extent_separation.cpp: on #122's macOS job,wrong_copyendedUnresolved [reason=solver.timeout]after its whole 120 s budget, where the test expects its certified failure (it takes 1.7 s on Linux). Its query is the one main builds; whether model search finds the counterexample through the loop invariant over a framed heap depends on the solver's search order, which varies from run to run (Z3 hashes some objects by address).The function's point is that separating
valid(p, n)extents does not hide a real failure: a copy that writes zeros must fail whereaholds anything else. A copy of two cells shows the same without a loop, and its counterexample needs no search:wrong_copynow fails its postcondition in milliseconds, and the test passes.The quantified loop invariants over memory keep their own false cases in the loop tests.