Repository navigation
CT-010: ScoutAI health pass (a11y targets, keyboard regions, npm start) - #207
Draft
Swissystem7 wants to merge 1 commit into
Draft
Swissystem7 wants to merge 1 commit into
Swissystem7 wants to merge 1 commit into
Conversation
- 44px tap targets on all four pages (skip links, step buttons, sliders, checkbox/radio labels, footer and nav links) - keyboard-focusable named regions for the five scrollable boxes axe flagged - npm start: zero-dependency static server that only serves shipped files - engines field, test evidence refreshed, new test/ct010-health.test.js Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VbVqhR94E7eMGDWaB4wGGA
Owner
Author
Swissystem7
pushed a commit
that referenced
this pull request
Nov 3, 2026
parseMetricHash turned '#g=abc' into grit 0, so another weight dominated. Found by CT-010 (#207), which could not touch demo.js. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Superseded by #206. The commit from this PR (44px targets, keyboard scroll regions, |
6 of 12 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CT-010 (owner: Goza). Health pass for ScoutAI. Draft only, nothing merged.
Scope limit: overlap with open PR #206
Before starting I checked open PRs. Draft PR #206 (CT-007 health pass) already changes
ARCHITECTURE.md(new),README.md,demo.js,package-lock.json(new) andtest/byod.test.js. Per the CT-010 rules this PR does not touch any of those files. So the ARCHITECTURE.md and README parts of CT-010 are left to #206, and the one bug I found indemo.jsis reported below, not fixed. #16 is a decision issue, not a PR. This PR does not change product direction.What changed
index.html,trap/index.html,licence.html,offer.html. Measured at a 375px mobile viewport before → after: index 31 → 0, trap 46 → 0, licence 7 → 0, offer 7 → 0 targets under 44px. Checkboxes and radios are now 24px and sit inside labels that are at least 44px tall, so the label is the tap target.scrollable-region-focusable(serious) flagged 5 scrollable boxes that keyboard users could not scroll:#explorerTable,#methodText,#exportJson,#atticRank,#archiveDump. Each now hastabindex="0",role="region"and a Hebrewaria-label. axe WCAG 2.1 A/AA now reports 0 violations on all four pages, contrast included.npm start(tools/serve.js), a zero-dependency static server on127.0.0.1:8080. The lab can't run fromfile://because it fetchesdata/*.json. The server only serves the shipped product: it refuses.git,attic/,tools/,test/andnode_modules/, and it can't be tricked into reading files outside the repo. Addedengines: node >=18. Runtime dependencies are still zero.test/ct010-health.test.jscovers the server (serves the page, the dataset andtrap/; 404 for missing files; refuses paths outside the repo or in blocked folders), the 44px CSS rules on each page, and the keyboard regions.npm test(one command): 155 pass, 0 fail. Before this PR it was 147/147.TEST_EVIDENCE.md: replaced the stale "runs 3 files" command with the currentnode --testrun.Checked, nothing to fix
.gitignorealready covers.env,*.keyand*.pem.;-CSV) whose names, teams, positions and provenance contain"><img onerror>/<svg onload>, plus the same payload in#sel=,#cmp=and#out=, then clicked every button. No script ran and there were no page errors. EveryinnerHTMLsink goes throughescapeHtml..github/workflowswas not touched.Bugs found but not fixed (file is locked by #206)
demo.jsparseMetricHash: a non-numeric value in a shared link sets that weight to 0 instead of the default. For example,#g=abcgives Grit 0, not 40, and Clutch then dominates. The comment abovepick()says a missing key keeps its default, but a malformed key doesn't. Fix: inpick(), fall back when!Number.isFinite(Number(value)). Belongs in CT-007: ScoutAI health pass #206 or a follow-up after it merges.Needs Aviran's decision
parseMetricHashfix go into CT-007: ScoutAI health pass #206 or a separate follow-up PR?npm startonce CT-007: ScoutAI health pass #206 merges..github/copilot-instructions.mdstill saysnpm testruns only three files. That is stale, but agent-instruction files were outside my brief, so I didn't touch it.How to verify
Generated by Claude Code