Conversation
adaussy
previously requested changes
Sep 7, 2026
adaussy
left a comment
adaussy
left a comment
Contributor
There was a problem hiding this comment.
Except from the comment on the header that is not up to date this change is fine by me.
seidewitz
dismissed
adaussy’s stale review
September 8, 2026 17:18
Reviewer wrote in prior comment that he was fine with this PR except for a copyright header that has now been fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a bug in the
PortUsageAdapter.PortUsagespecializesOccurrenceUsage, butPortUsageAdapterextendedUsageAdapterinstead ofOccurrenceUsageAdapter. This meant thattimesliceandsnapshotwere not handled correctly for port usages.This PR corrects
PortUsageAdapterto extendOccurrenceAdapter.