Repository navigation
Merge main into next: #348 and #349 - #350
Merged
Merged
Conversation
…vents
sseFailure wrote "data: {error}\ndata: [DONE]\n\n", one SSE event with two
data lines. A client joins those lines with a newline, so it read the
error object followed by "[DONE]", failed to parse it and reported
"malformed server-sent event JSON" with no reason. A blank line now ends
the error event before DONE.
TestKeepAliveFailureEmitsErrorEvent reads the stream the way an SSE
client does and requires each event's data to be JSON or [DONE].
Closes #346
service install --notify wrote the bare berth.exe to the user's Run key. berth.exe is a console program, so a console opened at every logon, and closing it sent CTRL_CLOSE_EVENT and ended the tray. The Run value is now wscript on a berth-notify.vbs stub, the launcher the other units use: no console, berth notify runs hidden, and its output goes to logs\berth-notify.log. Uninstall removes the stub with the Run value. Closes #344
fix(gateway): send a streamed start failure's error and DONE as two events
…-at-logon # Conflicts: # CHANGELOG.md
fix(notify): start the Windows tray at logon without a console
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings #348 and #349 from
mainintonext. No conflicts, and the CHANGELOG lines sit under## [Unreleased]. Full proof is green.