Skip to content

Merge main into next: #352 - #353

Merged
T-Crypt merged 3 commits into
nextfrom
T-Crypt/main-into-next-windows-tests
Nov 16, 2026
Merged

T-Crypt merged 3 commits into
nextfrom
T-Crypt/main-into-next-windows-tests

Conversation

@T-Crypt

@T-Crypt T-Crypt commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Brings #352 from main into next. No conflicts, and the CHANGELOG lines sit under ## [Unreleased]. Full proof is green.

…tory

TestServiceUninstallWindows, TestServiceUninstallWindowsIgnoresEndFailure
and TestServiceInstallWindowsCommandFails did not set XDG_STATE_HOME, so
defaultStateDir fell back to the user's own state directory. The fake ops
stand in for schtasks only, and the uninstall's os.Remove of each unit's
stub was real: go test on a live Windows install deleted berthd.vbs,
berth-gateway.vbs and berth-harbor.vbs. Each test now uses a temporary
state directory, as the rest of the file does.

Reproduced under wine with stubs planted in the profile's state
directory: removed before, kept after, across the whole cli package.

Closes #351
test(cli): keep the Windows service tests out of the real state directory
@T-Crypt
T-Crypt merged commit a18488b into next Nov 16, 2026
2 checks passed
@T-Crypt
T-Crypt deleted the T-Crypt/main-into-next-windows-tests branch November 16, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant