Repository navigation
Merge main into next: #352 - #353
Merged
Merged
Conversation
…tory TestServiceUninstallWindows, TestServiceUninstallWindowsIgnoresEndFailure and TestServiceInstallWindowsCommandFails did not set XDG_STATE_HOME, so defaultStateDir fell back to the user's own state directory. The fake ops stand in for schtasks only, and the uninstall's os.Remove of each unit's stub was real: go test on a live Windows install deleted berthd.vbs, berth-gateway.vbs and berth-harbor.vbs. Each test now uses a temporary state directory, as the rest of the file does. Reproduced under wine with stubs planted in the profile's state directory: removed before, kept after, across the whole cli package. Closes #351
test(cli): keep the Windows service tests out of the real state directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings #352 from
mainintonext. No conflicts, and the CHANGELOG lines sit under## [Unreleased]. Full proof is green.