feat: distinguish smoke skips from passes and assert post-exit sidecars - #125
Merged
Conversation
Exit 0 was the only green. A version skip would have been a vacuous pass. The host runner records SKIP only on exit 77 plus a SMOKE_SKIP reason below --min-version; a missing sidecar after Blender exits is FAIL; a leg with zero PASSes is red. Signed-off-by: fOuttaMyPaint <TMhospitalitystrategies@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
GitHub rejects runner.temp at job-level env, so the workflow never parsed and the PR never got a smoke job. Signed-off-by: fOuttaMyPaint <TMhospitalitystrategies@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
CI canaries on PR head live-run-proven (CI Linux portable)
Both legs:
First push ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/smoke/run_example.py+ catalogtests/smoke/catalog.json+summarize.py.SMOKE_SKIP: <reason>and only when--min-versionis above this Blender. Exit 0 with that marker is FAIL (vacuous). Skip on a version that should run is FAIL. Zero PASSes is red (exit 2).--expect-sidecar/$BDT_SMOKE_SIDECAR), asserted after Blender dies. No gallery still.tests/smoke/.Today, before this PR (inspection)
blender-smoke.ymlwas 45 independentset -esteps. Exit 0 = green. There was no skip channel.run_smoke.pywas pass-or-die thenALL SMOKE CHECKS PASSED. A 5.0-only example thatsys.exit(0)on 4.5 would have been indistinguishable from a real pass.Evidence
live-run-proven
.scratch/blender-5.2.1-windows-x64/blender.exeBlender 5.2.1 LTS (9e2066aef7ef):--min-version 99.0+ always-skip canary[SKIP]proc_exit77--min-version 4.0+ always-skip canary (should run)[FAIL] skipped on 5.2 but min-version 4.0 (should run)--expect-sidecarafter process death[PASS]--omit-sidecar+--expect-sidecarmissing post-exit sidecarsummarize1 PASS + 1 SKIPsummarizeall SKIPevery example skipped; job is not green.scratch/blender-4.5.11-windows-x64/blender.exeBlender 4.5.11 LTS: expected skip wrapper exit 0[SKIP].python tests/smoke/test_harness.py -v— 16 tests OK (no Blender). Inverted canaries are also CI steps that assert wrapper exit 1.run_smoke.pystill green on 5.2.1:12 passed, 0 skipped.inspection-only: YAML splice, catalog listing matches plugin 45 example dirs.
Test plan
feat:→release.ymlRELEASE (expect v0.48.0)