feat: add CLI falsifiers and exit tables to ten mesh examples - #142
Merged
Conversation
Default smoke stays green. Each flag feeds degenerate input into an existing assertion. swatch-grid --no-verify was a skip-flag; it is gone. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 8, retrofit batch 2. Nine mesh/GN examples plus a
swatch-gridrepair. Each flag feeds degenerate input into an existing assertion. Default smoke path is unchanged. README exit tables document every nonzero code the script already returned; no codes were renumbered.--same-axis/--flat-source/ #141 shape. Not skip-flags, path selectors, or second witnesses.Parent of this branch is
main@cfc869f(v0.58.0), after squash-merge of #141.bmesh-gear--no-extrudeextrude_face_region; closed-form counts still expect two ringscollision-hull-proxy--shrink-hull*= 0.5; containment plane test still runsdegenerate-bevel-weld--both-safeSAFE_OFFSET; zero-area closed form still expectedgn-instance-grid--one-cellGRID_HALFgn-sdf-remesh--no-sdfmesh-hygiene-audit--inject-ngoninject_defect(..., "ngon")triangulate-tangents--zero-uv(0,0); polar closed form still checkeduv-layer-grid--precreate-on-hazardwave-displace--flatforeach_set; z-span gate still runsswatch-grid--same-base(0.5,0.5,0.5)on every swatch; distinct-count still 6No substitutions. All nine took a genuine falsifier.
swatch-grid--no-verifycheckLive-run-proven (
rg -n "no-verify" tests/ .github/ scripts/ examples/swatch-grid/pluscatalog.json):examples/swatch-grid/(the flag itself, now gone; README notes the removal).tests/,.github/,scripts/,tests/smoke/catalog.json: no matches.--no-verify. Removing it does not break smoke.--no-verifyskipped the pixel check and passed vacuously. It was not renamed. It was deleted. Pixel verification still always runs when--outputis passed.A flag that only broke
verify_pngwould exit 0 on the check-only smoke path, so--same-basetargetscheck_distinct_swatcheson the default (no-render) path. That is the existing color-identity contract, not a new witness.catalog.jsonwas not modified. Falsifiers are not on the default smoke path.Live-run table
Binaries (each
--versionfrom that exe):.scratch/blender-4.5.11-windows-x64/blender.exe4db51e9d1e1e.scratch/blender-5.1.2-windows-x64/blender.exeec6e62d40fa9.scratch/blender-5.2.1-windows-x64/blender.exe9e2066aef7efCheck-only (no
--output). Observed exit codes were identical on all three binaries.bmesh-gear--no-extrudecollision-hull-proxy--shrink-hulldegenerate-bevel-weld--both-safegn-instance-grid--one-cellgn-sdf-remesh--no-sdfmesh-hygiene-audit--inject-ngontriangulate-tangents--zero-uvuv-layer-grid--precreate-on-hazardwave-displace--flatswatch-grid--same-baseLive-run-proven: the 60 headless invocations (10 × 2 × 3). No falsifier exited 0. No default exited nonzero.
5.1 evidence in this PR body is local, from
.scratch/blender-5.1.2-windows-x64/blender.exe. CI 5.1 is theneeds-5.1smoke job on this PR, not this table.Inspection-only: README table wording vs
sys.exit/return Nin each script;rgover harness paths for--no-verify; remaining-count arithmetic (Phase 6's 41 − 6 from #141 − 10 here = 25 examples with no extra CLI flag). Did not restylebake-normal-high-to-lowor the six from #141. Did not touch pathology/sidecar five,catalog.json,VERSION,CHANGELOG.md,release.yml,blender-smoke.yml,pages.yml, gallery assets.Test plan
needs-5.1Remaining no-falsifier pool
25 of 55 example dirs have no extra CLI flag (
--output/--engine/--samples/--widthexcluded). Out of scope for this PR.