feat: add CLI falsifiers and exit tables to the remaining twelve examples - #144
Merged
Conversation
…ples Closes the last behavior gap in the retrofit: every example now has a flag that makes an existing assertion fail, without touching Grease Pencil version shims or changing any exit code value. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Inspection-only documentation so every shipped example lists its file-local nonzero codes. No flags, no behavior, no code-value changes. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the example-falsifier retrofit on both axes: 55/55 flags and 55/55 README exit tables. Two commits: B1 behavior, B2 docs-only.
Issue #138's checker is still out of scope. This PR is what makes it buildable as an enforcing gate.
Part A already landed (context, not this PR)
#143 squash-merged as
89ae4eb(feat: add CLI falsifiers and exit tables to thirteen rigging examples). Release cut v0.60.0. Pages deployed. Smoke did not re-run onpush(intentional). #131 and #138 remain OPEN.B1 — final 12 falsifiers
Same treatment as batches 1–3: a flag that changes the input so an existing assertion fails. No assertion skipped, disabled, or bypassed. No exit-code value changed. Grease Pencil version shims were left alone; both GP flags are version-independent RNA (
use_contour,cyclic).--check-pixelsonvse-cut-liststays a second witness; the falsifier beside it is--swap-inputs.Live-run-proven on local binaries (default must be 0; falsifier must be the documented code on all three). Falsifier was never 0.
4db51e9d1e1e)ec6e62d40fa9)9e2066aef7ef)--threshold-high--no-caps--no-contour--open-strokes--skip-link--opaque-alpha--same-tint--unlink-sky--wrong-body--no-keys--swap-inputs--swap-inputsBinaries:
.scratch/blender-4.5.11-windows-x64/blender.exe,.scratch/blender-5.1.2-windows-x64/blender.exe,.scratch/blender-5.2.1-windows-x64/blender.exe. 5.1 evidence here is local; CI 5.1 is the labeled job.Falsifiers are not on the default smoke path. No
catalog.jsonedits.B2 — thirteen README exit tables (inspection-only)
No flags, no behavior, no code-value changes, no local Blender runs. Codes copied from each script as they are.
export-preset-axisexiting 9 is correct.Pathology / sidecar (no gallery, by design):
exit-pre-sidecar— 0, 1, 2, 77 (bullet list converted to the numbered table)coincident-vert-weld— 0–4gn-bundle-roundtrip— 0–5, 77ngon-triangulate— 0–4unapplied-scale-gltf— 0–4Existing flags, missing tables:
cross-version-property-delete— 0–7, 10, 12export-preset-axis— 0–11 (including 9)gn-zone-iterate— 0–6, 10, 12lightmap-uv-channel— 0–11modular-kit-snap— 0–9, 11 (check_framingis called with a documented deviation, so 10 is not reachable)socket-attach-points— 0–11usd-export-evaluation-mode— 0–6, 10, 12vertex-color-ao— 0–11Final counts (this branch, before opening)
Falsifier flags 55/55:
README exit tables matching CONTRIBUTING “Exit codes” / bake-normal (
## Exit codes+| Code | Meaning |) 55/55:Test plan
needs-5.1