fix(datagrid): honor binary UUID display - #2159
Draft
sophiathedev wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display As > UUIDfor generic 16-byte SQL binary cells in the grid,row inspector, VoiceOver, and single-cell copy
Raw Valuechoice and isolate formats by duplicate columnoccurrence and pinned result set
display format changes
order remain owned by the MongoDB driver
Root cause
The typed binary formatting path returned compact hex before consulting the
column's display format. The same early return also affected direct cell copy.
The surrounding display state was keyed only by column label and tab, so format
changes could leave mounted cells, filters, the inspector, or pinned results
using stale state.
MongoDB boundary
Issue #2157 led to this investigation, but MongoDB subtype 3 values cannot be
safely interpreted without their configured Java, C#, or Python legacy byte
order. This change does not guess that order. If the driver has not decoded a
MongoDB binary UUID, the host keeps it as hex and the connection's Legacy UUID
Encoding setting remains authoritative.
Related to #2157.
Preview
The preview uses an isolated SQLite fixture with two generic 16-byte BLOBs.
Before
Binary cells use compact hexadecimal output.
After
Display As > UUIDrenders the same stored bytes as lowercase UUIDs.Testing
accessibility, inspector-trigger, and MongoDB codec/flattener suites
interaction, filter-state, and tab-switch suites
git diff --check