Repository navigation
feat(export): set Structure, Drop or Data for a whole database or group - #3857
Merged
Merged
Conversation
|
Absolutely perfect! Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VimNormalModeChordUITestsfailure.Before / after
After: the database row's Drop and Data are unticked, which unticks them for every table.
Test plan
ExportOptionColumnTests, the newExportObjectTreeCoordinatorTestscases,ExportTreeBuilderTests.reloadKeepsRowScope,BackupScopeModelTestsSpace cases andMQLExportReadsRowsTestspass locally (117 cases in the export, backup and format suites).SQLEditorFocusClaimTestsfails without the editor fix. The Vim, Emacs, autocomplete, window focus, agent mode, history and query run UI flows pass locally.ExportUITests.testExportingEveryTableAsStructureOnly: tick the fixture database, untick Drop and Data on its row, export SQL. The file has sixCREATE TABLE, noINSERT INTO, noDROP TABLE.verify.sh pluginscould not link DamengDriver: this checkout has nolibdameng_bridge.a. The two export plugins built and their tests ran.Docs: TableProApp/docs#133