Repository navigation
feat(linux-editor): switch a query tab's database on SQL Server, ClickHouse, Cassandra and MongoDB - #3898
Merged
datlechin merged 37 commits intoOct 31, 2026
Conversation
…tabase from the editor bar
…kHouse, Cassandra and MongoDB
…where a connection reaches several
…or-database-switch # Conflicts: # linux/crates/app/src/ui/editor/tab_scope.rs # linux/data/resources/ui/sql-editor.ui
…lete only where the catalog reaches
…or-database-switch-more # Conflicts: # linux/crates/app/src/ui/editor/editor_session_slot.rs # linux/crates/core/src/dialect/sql_dialect.rs # linux/crates/drivers/mongodb/src/dialect.rs
… tabs with each driver's own means
…left the session in
…or-database-switch
…end a session whose move did not finish
…or-database-switch-more
… a name, and drop a MySQL session a USE lost
…or-database-switch-more
…or-database-switch-more
…or-database-switch-more
…wn database, and offer one when none is open
…or-database-switch-more
…or-database-switch-more
…abase-switch-more
datlechin
enabled auto-merge (squash)
October 31, 2026 04:30
datlechin
added a commit
to sedax90/TablePro
that referenced
this pull request
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditorSession::use_database:USE [name], a]doubled, on the tab's own session.use_keyspace, which refuses a name CQL cannot carry. A move that does not finish ends the session, since the driver records the keyspace before the server confirms it.USEin the editor now applies to the statements after it: every request names its database, which overrode the session'sUSE.Test plan
tablepro-driver-mssqla_session_moves_to_a_database_by_its_nameandthe_servers_databases_are_listed_for_a_query_tab;tablepro-driver-clickhousea_session_runs_in_the_database_it_moved_to.sql_syntax::catalog_change::tests::a_use_names_its_database,mssqldialect::tests::a_bracket_in_a_name_is_doubled.verify.shbuild, the driver unit tests,tableproeditor tests, lint.