Repository navigation
feat(welcome): show a Black Friday offer to people without a license - #3995
Merged
Merged
Conversation
The Welcome window shows "Black Friday: 40% off Pro until Dec 1" under Support TablePro for prospects, from 2026-11-24 00:00 UTC up to 2026-12-01 08:00 UTC, linking to the sale page with ref=app-black-friday. A TimelineView redraws the line at the two instants. DatedSaleSchedule replaces .explicit, which on macOS 27 draws its first entry as the current date and never delivers its last entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supportAudience == .prospect), from 2026-11-24 00:00 UTC up to 2026-12-01 08:00 UTC. It opens https://tablepro.app/black-friday?ref=app-black-friday, and the site applies the code.DatedSaleholds the two instants, the percentage and the page, with a half-openisLive(at:). The dates are fixed in the build, so the notice comes out in the first release after the sale.TimelineViewredraws the line at exactly those two instants, so it appears and disappears while the window stays open, with no timer.DatedSaleSchedulereplaces.explicit([start, end]): measured on macOS 27.0.1,.explicitdraws its first frame with its first entry as the date, so the line would show three weeks early, and it never delivers its last entry, so the line would stay after the sale.TimelineViewstill takes the stack's spacing. Outside the sale the Welcome window lays out exactly as before.SupportReferrer.blackFridayandSupportLinks.blackFriday(_:)build the tagged link, the waypricing(_:)does.Test plan
DatedSaleTests: one second before the start, the start, one second before the end and the end; the constants match the decided ISO instants.DatedSaleScheduleTests: the schedule's entries before, at the start of, during and after the sale.SupportLinksTests: the exact/black-fridayURL with its ref; the new referrer joins the distinctness and attribution checks.The date follows the viewer's region: this Mac writes "1 Dec", en_US reads "Dec 1". A third local build that opened the sale 20 s after launch and closed it 20 s later showed the line appear and then disappear with the window left open.
Notes
DatedSale,DatedSaleSchedule, the row and the referrer can come out in the next release.