Repository navigation
fix(plugin-snowflake): keep Snowflake sign-in working after a downgrade - #3996
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
November 2, 2026 18:36
datlechin
disabled auto-merge
November 2, 2026 19:23
…owngrade # Conflicts: # .claude/rules/data-sync-storage.md
datlechin
enabled auto-merge (squash)
November 2, 2026 19:59
datlechin
disabled auto-merge
November 2, 2026 20:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snowflakecomputing.comand only while the per-host item is missing. A token is never used for another host.SnowflakeTokenCachein TableProSnowflakeCore, shared by both stores and testable there..claude/rules/data-sync-storage.mdpaths now cover the types persisted to disk, the Keychain, UserDefaults or iCloud, so the release storage check sees them. Adds the Snowflake tokens to the store table.Test plan
SnowflakeTokenCacheTests(TableProSnowflakeCoreTests): the old item survives the copy, the per-host key wins afterwards, other hosts never read the old key, clear removes both. Fails with the old copy-then-delete.SnowflakeAccountTestspass.