Repository navigation
fix(drivers): match SQL Server keys exactly and close Linux read gaps - #4039
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
November 4, 2026 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WesselsandWeßelsare twovarcharkeys, yet both matched the Unicode value, so editing one changed both rows. Foreign key previews keep matching by the column's collation, soabcstill findsABC.relation "16385" does not exist. The catalog reads now use the table's resolved OID as an OID.publicwhen the login's search_path listspublicahead ofpg_catalog. A built-in column type's cast now namespg_catalog.pragma_optimizeonly as a value, a column or an alias..or$, such as@1.Not fixed here
charorvarcharkey compare as Unicode, so under a SQL collation a childWeßelscan show aWesselsparent. Matching by the column's own rules needs its collation, which the app does not read yet.clickhousecrate, 0.15.3 included, reads an HTTP error body whole on every request. Bounding it needs an upstream fix or an HTTP layer of our own.Test plan
MSSQLRowMatchTests, iOSSQLBuilderSingleRowLookupTestsandFilterSQLGeneratorTestscover the SQL Server key match, the foreign key lookup and the combining mark.apple/scripts/probes/check-mssql-string-literals.shagainst SQL Server 2022: an update and a delete on avarcharkey, with and without a primary key and read through a cast tonvarchar, leave the other row alone.a_save_casts_to_the_built_in_type_a_lookalike_shares_a_name_withsaves aninetcolumn past a trappingpublic.inetdomain.a_pragma_name_as_a_value_column_or_alias_reads_on_sqlite, the@1,@.sand@$shistory cases, and two ClickHouse login reply tests.