Repository navigation
fix(safe-mode): rate pg_background, pg_cron and TimescaleDB calls as writes - #4043
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/crates/core/tests/fixtures/state_changing_functions.jsonholds every family, the DuckDB-only list included, and both suites compare against it.Deliberately not fixed here
||,U&'', the remote dialect, which argument holds the SQL (dblink's(text, text)overloads are ambiguous without types), views andWITH NO DATA, and quadratic or unbounded scans. It needs its own design.U&"...",UESCAPE, an escapedcronschema) kept turning up bypasses, so they go to a follow-up.WITH schedule(day) AS (...), reads as a call of that function. Both scanners already do this forsetval,crosstaband the rest. The bare pg_cron names make it easier to hit.Test plan
SQLStatementClassifierTests(new: extension writes and reads),SQLStateChangingFunctionsTestsand the TableProQuery suites, throughverify.sh package TableProCore.cargo test -p tablepro-coreand clippy in the Linux image, includinga_function_that_runs_sql_text_or_signals_writes.