ci: fix the version suggestion for Dependabot PRs and mixed tags - #18
Merged
Conversation
The job fails when the prerelease:* label is missing, and Dependabot never adds it, so every dependency bump showed a red check for a suggestion that does not apply to it.
debba
added
the
prerelease:beta
git describe picked the explain-v1.0.0-beta.1 npm tag, which shares the commit with v1.0.0-beta.1, and the suggestion script failed to parse it. Match only v* tags.
debba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All twelve open Dependabot PRs show a failing
Version suggestioncheck, and PR #17 failed it too despite carrying the label.What changed
ci.yml: theversion-suggestionjob is skipped when the actor isdependabot[bot]. It exits with an error when theprerelease:*label is missing and Dependabot never adds one; dependency bumps do not drive a plugin version on their own. Human PRs keep the label requirement documented in the README.ci.yml: the baseline version is derived fromv*tags only.git describe --tagson main pickedexplain-v1.0.0-beta.1, the npm parser tag that shares its commit withv1.0.0-beta.1, and the suggestion script failed withCannot parse version.Notes
Two Dependabot PRs also fail
EXPLAIN parser packagefor real reasons: #14 (vitest 3 -> 4) breaks the typecheck onnode:fs/promisestypes and #16 (typescript 5.9 -> 7.0) crashes vitest's typechecker. Those are major bumps to review separately.