feat(lilygo-tdeck-max): wire up the EPD frontlight - #636
Conversation
Devicetree only, on top of the optional-frontlight support from TactilityProject#633. The panel is reflective, so this lights it from the front, but it is still a BACKLIGHT_TYPE device and shows up as the usual Display brightness slider. BL_PWM is GPIO41. It has to use LEDC timer/channel 1 because timer/channel 0 is already taken by the keyboard backlight on this board. The backlight node is left disabled so Boot starts it and applies the stored brightness, which is the same handling every other board's backlight gets. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe device tree connects the EPD display to a new Merge Risk: ⚪ Minimal · up to This change adds the LilyGO T-Deck Max EPD frontlight through its existing display brightness controls without altering broader runtime behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The order of display_backlight is likely causing the build failure. It needs to be above the device that references it. |
Closes #629. Builds on #633, which is now merged.
Devicetree only. The panel is reflective, so this lights it from the front, but it is still a
BACKLIGHT_TYPEdevice and shows up as the usual Display brightness slider.BL_PWMis GPIO41. It has to use LEDC timer/channel 1, because timer/channel 0 is already taken by the keyboard backlight on this board.The backlight node is left
status = "disabled"so Boot starts it and applies the stored brightness, the same handling every other board's backlight gets.Tested: LilyGO T-Deck Max. The brightness slider appears in Display settings and lights the panel.
Two things worth noting, neither addressed here:
Boot logs
W ledc: GPIO 41 is not usable, maybe conflict with others. It is benign:pwm_backlight'sstart()reserves the pin, then the boot brightness apply reserves it again, and the secondesp_gpio_reserve()warns. The panel lights correctly. Happy to look at silencing it separately if you would rather not ship a warning.This is also the board that motivated your
backlight_set_brightness_default()idea on #625: it comes up at the board-agnostic 200/255 default, which lights a panel that is perfectly readable without it. I have deliberately left that out of here since it touches every board.Summary by CodeRabbit